Better error messages from vg haplotypes #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like CI failed when testing the current version of the tube map against vg. I think the problem is an intermittent test failure in the tube map, caused possibly by cross-talk between different tests, or by not using the testing library right. I've slightly improved the tube map tests, and I haven't been able to trigger it locally. I've rerun the job here; hopefully it passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg haplotypes.Description
Better error messages from
vg haplotypes, particularly when the KFF file or the haplotype information file cannot be opened. Also try to catch more exceptions and report the errors without the garbage surrounding uncaught exceptions.