Fix build on Ubuntu 24.04.1 / GCC 13.2.0 #4394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged that pr!
…On Tue, Sep 10, 2024, 11:06 AM Glenn Hickey ***@***.***> wrote:
My video drivers bugged out and I ended up just re-installing Ubuntu from
scratch instead of wasting more time trying to fix it. This put me on
Ubuntu 24.04.1 with GCC 13.2.0, giving seeming to give rise to an issue I
always try to avoid: me being the first developer to build on a new
compiler release....
This PR fixes the usual issues like GCC getting stricter about which
standard headers you can expect to include others, but also one on string
command = argv[1] error in main.cpp that I still don't understand (but
smells like a gcc bug).
Ideally I'll hold off merging until @yoheirosen
<https://github.com/yoheirosen> merges this pr
<yoheirosen/sublinear-Li-Stephens#11>, to avoid
switching to repo to my fork as done currently...
------------------------------
You can view, comment on, or merge this pull request online at:
#4394
Commit Summary
- fa824c1
<fa824c1>
fix build on Ubuntu 24.04.1 / GCC 13.2.0
File Changes
(5 files <https://github.com/vgteam/vg/pull/4394/files>)
- *M* .gitmodules
<https://github.com/vgteam/vg/pull/4394/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584>
(2)
- *M* deps/kff-cpp-api
<https://github.com/vgteam/vg/pull/4394/files#diff-abd896d4b26338be66ba63e6f8f71e7230b14e8ce91e8c7625a444541aef6cfc>
(2)
- *M* deps/sublinear-Li-Stephens
<https://github.com/vgteam/vg/pull/4394/files#diff-3ebc7a49c68644027575b977b2da5e0204e7714f83d6a1f651e11cc3ad4c9ccb>
(2)
- *M* src/main.cpp
<https://github.com/vgteam/vg/pull/4394/files#diff-34d21af3c614ea3cee120df276c9c4ae95053830d7f1d3deaf009a4625409ad2>
(9)
- *M* src/multipath_mapper.cpp
<https://github.com/vgteam/vg/pull/4394/files#diff-6ebd34d7b577f051f2e21dc965426dcad9f4d1a078680dbb80312d31376303cb>
(6)
Patch Links:
- https://github.com/vgteam/vg/pull/4394.patch
- https://github.com/vgteam/vg/pull/4394.diff
—
Reply to this email directly, view it on GitHub
<#4394>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4ZYLULMTT5TEWWQ6FMZVLZV4YIJAVCNFSM6AAAAABN7JUKICVHI2DSMVQWIX3LMV43ASLTON2WKOZSGUYTOMRRGU4DGNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My video drivers bugged out and I ended up just re-installing Ubuntu from scratch instead of wasting more time trying to fix it. This put me on Ubuntu 24.04.1 with GCC 13.2.0, seeming to give rise to a situation I always try to avoid: me being the first developer to build on a new compiler release....
This PR fixes the usual issues like GCC getting stricter about which standard headers you can expect to include others, but also one on
string command = argv[1]error inmain.cppthat I still don't understand (but smells like a gcc bug).Ideally I'll hold off merging until @yoheirosen merges this pr, to avoid switching to repo to my fork as done currently...