Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1653: R2D2 Docs Updates #2433

Merged
merged 81 commits into from
Apr 16, 2024
Merged

DOCS-1653: R2D2 Docs Updates #2433

merged 81 commits into from
Apr 16, 2024

Conversation

sguequierre
Copy link
Collaborator

@sguequierre sguequierre commented Jan 25, 2024

All R2D2 work should be based off this branch

How to contribute

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 25, 2024
@viambot
Copy link
Member

viambot commented Jan 25, 2024

Overall readability score: 55.36 (🔴 -0.03)

File Readability
changelog.md 36.52 (🔴 -0.13)
part.md 8.99 (🔴 -7.59)
remote-part.md 65.61 (-)
resource.md 6.36 (🟢 +0)
setup.md 55.62 (-)
troubleshooting.md 59.06 (🔴 -0.38)
_index.md 57.32 (🟢 +0.5)
View detailed metrics

🟢 - Shows an increase in readability
🔴 - Shows a decrease in readability

File Readability FRE GF ARI CLI DCRS
changelog.md 36.52 33.28 15.05 18.7 13.07 7.55
  🔴 -0.13 🟢 +0 🔴 -0.01 🟢 +0 🔴 -0.06 🔴 -0.01
part.md 8.99 5.32 17.06 22 19 9.51
  🔴 -7.59 🔴 -6.9 🔴 -3.18 🟢 +0 🟢 +0 🔴 -0.31
remote-part.md 65.61 54.39 8.11 10.5 13.42 6.84
  - - - - - -
resource.md 6.36 0 16 22 19 10.62
  🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0 🟢 +0
setup.md 55.62 48.13 11.19 15.3 12.42 6.25
  - - - - - -
troubleshooting.md 59.06 44.44 9.99 13 12.42 6.67
  🔴 -0.38 🟢 +0.1 🟢 +0 🔴 -0.1 🔴 -0.18 🟢 +0
_index.md 57.32 42.11 10.47 14.2 12.13 6.42
  🟢 +0.5 🔴 -0.1 🟢 +0.02 🔴 -0.1 🟢 +0.17 🟢 +0.12

Averages:

  Readability FRE GF ARI CLI DCRS
Average 55.36 47.43 10.79 13.27 12.04 7.59
  🔴 -0.03 🟢 +0.1 🔴 -0.1 🔴 -0.01 🟢 +0.06 🟢 +0.01
View metric targets
Metric Range Ideal score
Flesch Reading Ease 100 (very easy read) to 0 (extremely difficult read) 60
Gunning Fog 6 (very easy read) to 17 (extremely difficult read) 8 or less
Auto. Read. Index 6 (very easy read) to 14 (extremely difficult read) 8 or less
Coleman Liau Index 6 (very easy read) to 17 (extremely difficult read) 8 or less
Dale-Chall Readability 4.9 (very easy read) to 9.9 (extremely difficult read) 6.9 or less

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I asked on the other PR but did you check they're definitely keeping the all caps on CONFIGURE?

Comment on lines 72 to 75
2. Click the **+** icon next to your machine part in the left-hand menu and select **Component**.
3. Browse the list of available component types, and select the specific modular component you'd like to add.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making sure: you know you don't need to change these right? It will automatically render to be the correct numbers

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I know-- my vscode does that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you want to look at turning that off together 🙃

@@ -3,7 +3,6 @@ By default, the sample code does not include your machine API key and API key ID
We strongly recommend that you add your API key and API key ID as an environment variable and import this variable into your development environment as needed.

To show your machine's API key and API key ID in the sample code, toggle **Include secret** on the **Code sample** tab.
You can also see your API key and API key ID on your machine's **Security** tab.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's no longer true?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more security tab. I have another ticket to update that workflow

@sguequierre
Copy link
Collaborator Author

sguequierre commented Jan 29, 2024

I think I asked on the other PR but did you check they're definitely keeping the all caps on CONFIGURE?

Checking now!

edit: Yes

@@ -11,6 +11,7 @@ A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were intentional and to stop vale from complaining about it

@viambot
Copy link
Member

viambot commented Apr 16, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2433

@sguequierre sguequierre merged commit 59dee5b into main Apr 16, 2024
9 of 10 checks passed
@sguequierre sguequierre deleted the R2D2 branch April 16, 2024 20:11
sguequierre added a commit to sguequierre/docs that referenced this pull request Apr 25, 2024
Co-authored-by: Naomi Pentrel <[email protected]>
Co-authored-by: JessamyT <[email protected]>
Co-authored-by: sky leilani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants