-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-1653: R2D2 Docs Updates #2433
Conversation
Overall readability score: 55.36 (🔴 -0.03)
View detailed metrics🟢 - Shows an increase in readability
Averages:
View metric targets
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I asked on the other PR but did you check they're definitely keeping the all caps on CONFIGURE?
docs/registry/configure.md
Outdated
2. Click the **+** icon next to your machine part in the left-hand menu and select **Component**. | ||
3. Browse the list of available component types, and select the specific modular component you'd like to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just making sure: you know you don't need to change these right? It will automatically render to be the correct numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I know-- my vscode does that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you want to look at turning that off together 🙃
@@ -3,7 +3,6 @@ By default, the sample code does not include your machine API key and API key ID | |||
We strongly recommend that you add your API key and API key ID as an environment variable and import this variable into your development environment as needed. | |||
|
|||
To show your machine's API key and API key ID in the sample code, toggle **Include secret** on the **Code sample** tab. | |||
You can also see your API key and API key ID on your machine's **Security** tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's no longer true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more security tab. I have another ticket to update that workflow
Checking now! edit: Yes |
…on RBAC page R2D2 (#2412)
@@ -11,6 +11,7 @@ A clear and concise description of what the bug is. | |||
|
|||
**To Reproduce** | |||
Steps to reproduce the behavior: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were intentional and to stop vale from complaining about it
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/2433 |
Co-authored-by: Naomi Pentrel <[email protected]> Co-authored-by: JessamyT <[email protected]> Co-authored-by: sky leilani <[email protected]>
All R2D2 work should be based off this branch
How to contribute