Release PR for 2.1.0 #222
Merged
Release PR for 2.1.0 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All PacBio mlwh records are inspected, the ID is generated from scratch and compared to the one stored in the database.
Added a scripts to validate ID generator
Removed unused method
Update PacBioProductMetrics definition to include new per-product metrics
The descripton of the 'get_qc_states_by_id_product_list' method in npg_langqc.db.helper.qc says that when sequencing qc states are requested "it is guaranteed that the list of QcState objects has only one member". However, the implementation did not warrant this. It was possible to get an empty list of qc states.
Replaced multiple calls to retrieve qc states for a list of products. To simplify the logic, made this retrieval unconditional. Whether the wells are likely to have any associated qc state or not, an attempt to get qc states is made.
Where sequencing qc state for a single product is needed, it is more efficient to use `get_qc_state_for_product` method since it executes one SQL query, no additional filtering is involved.
Optimise QC state retrieval
... for some models in order to simplify instantiation of the objects.
Towards pydantic dataclass
Incorrect column name in mlwh
Refined the semantics of the 'study_names' field.
The function does a search on a table row, does not take any other arguments. The table class of this row is a natural home for this type of function.
The whole db is dropped and recreated at the point of creating a session factory.
PacBioWellSummary as a response model for well summaries
mouseOver event for the well button displays a tooltip with names of studies. Study-aware well button colour scheme.
This state will be assigned to wells when the outcome of the QC assessment depends on liasing with a third party. The existing 'On hold' state will be used for flagging internal investigations. As fas as QC statuses and workflow is concerned, the new state is handled in the same way as the existing 'On hold' state.
Display study names and highlight BIOSCAN stady
Introduced 'On hold external' QC state.
Described recent changes.
…langqc into update_toolchain
Update toolchain
Switched to light theme for the well button
Fixed an error in the db migration script
Updated the Copyright year. Added release instructions to README. Updated the CHANGELOG.
Updated app version to 2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.