Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start TinyCrypt deprecation #79566

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Start TinyCrypt deprecation #79566

merged 1 commit into from
Oct 17, 2024
+24 −0

Conversation

valeriosetti
Copy link
Collaborator

@valeriosetti valeriosetti commented Oct 8, 2024 •
edited
Loading

Description

This PR:

Work in progress

Remove all usages of TinyCrypt from the Zephyr's codebase as required from the API Lifecycle documentation

To do

@rettichschnidi
Copy link
Contributor

rettichschnidi commented Oct 8, 2024 •
edited
Loading

Maybe also mention that TinyCrypt is no longer maintained upstream?

@rettichschnidi rettichschnidi mentioned this pull request Oct 8, 2024
Closed
@ceolin ceolin self-requested a review October 9, 2024 17:29
@ceolin
Copy link
Member

ceolin commented Oct 9, 2024

Wonderful !

valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
drivers: crypto: remove TinyCrypt shim driver
8848993 
Remove the TinyCrypt's crypto shim driver and its usage in the
samples.
This is part of the deprecation process of TinyCrypt started
in zephyrproject-rtos#79566.

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti mentioned this pull request Oct 10, 2024
Closed
@valeriosetti valeriosetti force-pushed the deprecate-tinycrypt branch 2 times, most recently from fffff7c to a33c171 Compare October 10, 2024 09:53
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
drivers: crypto: remove TinyCrypt shim driver
ae774b5 
Remove the TinyCrypt's crypto shim driver and its usage in the
samples.
This is part of the deprecation process of TinyCrypt started
in zephyrproject-rtos#79566.

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti mentioned this pull request Oct 10, 2024
Merged
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
drivers: crypto: remove TinyCrypt shim driver
7035e08 
Remove the TinyCrypt's crypto shim driver and its usage in the
samples.
This is part of the deprecation process of TinyCrypt started
in zephyrproject-rtos#79566.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
board: remove references to TinyCrypt
77d0f0a 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove tags
referring to it.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
random: remove TinyCrypt usage
6625822 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove
TinyCrypt usage in random generators. This basically only affects
the CTR-DRBG random generator which from now only will only make
use of Mbed TLS.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
tests: crypto: remove usages of TinyCrypt
7bdf567 
This is part of the deprecation of TinyCrypt zephyrproject-rtos#79566.

Following tests are completely removed:
- tests/crypto/tinycrypt
- tests/crypto/tinycrypt_hmac_prng

Whereas in tests/crypto/secp256r1 only usage of TinyCrypt
is removed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
tests: crypto: remove usages of TinyCrypt
a419bd5 
This is part of the deprecation of TinyCrypt zephyrproject-rtos#79566.

Following tests are completely removed:
- tests/crypto/tinycrypt
- tests/crypto/tinycrypt_hmac_prng

Whereas in tests/crypto/secp256r1 only usage of TinyCrypt
is removed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
tests: crypto: remove usages of TinyCrypt
18265b2 
This is part of the deprecation of TinyCrypt zephyrproject-rtos#79566.

Following tests are completely removed:
- tests/crypto/tinycrypt
- tests/crypto/tinycrypt_hmac_prng

Whereas in tests/crypto/secp256r1 only usage of TinyCrypt
is removed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
jwt: remove TinyCrypt usage
fbb66ed 
As part of TinyCrypt deprecation process (zephyrproject-rtos#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
drivers: crypto: remove TinyCrypt shim driver
923ca47 
Remove the TinyCrypt's crypto shim driver and its usage in the
samples.
This is part of the deprecation process of TinyCrypt started
in zephyrproject-rtos#79566.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
board: remove references to TinyCrypt
52956f2 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove tags
referring to it.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
random: remove TinyCrypt usage
ff0efce 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove
TinyCrypt usage in random generators. This basically only affects
the CTR-DRBG random generator which from now only will only make
use of Mbed TLS.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
tests: crypto: remove usages of TinyCrypt
d44e0bd 
This is part of the deprecation of TinyCrypt zephyrproject-rtos#79566.

Following tests are completely removed:
- tests/crypto/tinycrypt
- tests/crypto/tinycrypt_hmac_prng

Whereas in tests/crypto/secp256r1 only usage of TinyCrypt
is removed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 10, 2024
@valeriosetti
jwt: remove TinyCrypt usage
85031f0 
As part of TinyCrypt deprecation process (zephyrproject-rtos#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
@valeriosetti valeriosetti marked this pull request as ready for review October 10, 2024 14:56
@zephyrbot zephyrbot added area: Crypto / RNG Release Notes To be mentioned in the release notes labels Oct 10, 2024
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 29, 2024
@valeriosetti
bt: change dependencies for BT_RPA
ae1b3c9 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit modified the dependencies of BT_RPA. Instead
of selecting TinyCrypt, it relies on BT_HOST_CRYPTO or
BT_CTLR_CRYPTO. This helps both in the deprecation process of
TinyCrypt, but also this is more correct dependency since these
2 symbols are extensively used in the rpa.c source code.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
bt: crypto/host: remove CONFIG_BT_USE_PSA_API symbol
b189368 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit removes CONFIG_BT_USE_PSA_API symbol. This
was used in BT crypto/host modules to select PSA crypto API over
TinyCrypt (which was the default until now). Since TinyCrypt is
removed and PSA crypto API is the new standard library for crypto
operations, CONFIG_BT_USE_PSA_API is no more needed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
bt: use PSA for HCI ECC and rename BT_TINYCRYPT_ECC
4165758 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit sets PSA Crypto API as the default library
to perform ECC-DH in HCI, replacing TinyCrypt. Therefore the
symbol BT_TINYCRYPT_ECC is renamed as BT_HCI_ECC.
Rreference in samples/tests are also fixed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
bt-mesh: remove BT_MESH_USES_TINYCRYPT
74ac6a9 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit removes TinyCrypt usage from BT mesh and
also the related CONFIG_BT_MESH_USES_TINYCRYPT symbol and it sets
PSA Crypto APIs as the default library for crypto operations.
Tests are also updated in this commit.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
bt: change dependencies for BT_RPA
075b855 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit modified the dependencies of BT_RPA. Instead
of selecting TinyCrypt, it relies on BT_HOST_CRYPTO or
BT_CTLR_CRYPTO. This helps both in the deprecation process of
TinyCrypt, but also this is more correct dependency since these
2 symbols are extensively used in the rpa.c source code.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
random: remove TinyCrypt usage
6b09d44 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove
TinyCrypt usage in random generators. This basically only affects
the CTR-DRBG random generator which from now only will only make
use of Mbed TLS.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
jwt: remove TinyCrypt usage
0637861 
As part of TinyCrypt deprecation process (zephyrproject-rtos#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
jwt: remove TinyCrypt usage
a44100c 
As part of TinyCrypt deprecation process (zephyrproject-rtos#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Oct 30, 2024
@valeriosetti
jwt: remove TinyCrypt usage
5cefd04 
As part of TinyCrypt deprecation process (zephyrproject-rtos#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
@jhedberg jhedberg mentioned this pull request Oct 31, 2024
Closed
mmahadevan108 pushed a commit that referenced this pull request Nov 5, 2024
@valeriosetti @mmahadevan108
drivers: crypto: deprecated TinyCrypt shim driver
dbda464 
As part of the deprecation process of TinyCrypt started in #79566,
this commit set the TinyCrypt based crypto shim driver as
deprecated.

Signed-off-by: Valerio Setti <[email protected]>
mmahadevan108 pushed a commit that referenced this pull request Nov 5, 2024
@valeriosetti @mmahadevan108
board: remove references to TinyCrypt
f4b7d15 
Following the deprecation of TinyCrypt (#79566) we remove tags
referring to it.

Signed-off-by: Valerio Setti <[email protected]>
mmahadevan108 pushed a commit that referenced this pull request Nov 5, 2024
@valeriosetti @mmahadevan108
random: remove TinyCrypt usage
3d45ee7 
Following the deprecation of TinyCrypt (#79566) we remove
TinyCrypt usage in random generators. This basically only affects
the CTR-DRBG random generator which from now only will only make
use of Mbed TLS.

Signed-off-by: Valerio Setti <[email protected]>
mmahadevan108 pushed a commit that referenced this pull request Nov 5, 2024
@valeriosetti @mmahadevan108
jwt: remove TinyCrypt usage
7f55748 
As part of TinyCrypt deprecation process (#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti
bt: crypto/host: remove CONFIG_BT_USE_PSA_API symbol
02b0bb0 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit removes CONFIG_BT_USE_PSA_API symbol. This
was used in BT crypto/host modules to select PSA crypto API over
TinyCrypt (which was the default until now). Since TinyCrypt is
removed and PSA crypto API is the new standard library for crypto
operations, CONFIG_BT_USE_PSA_API is no more needed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti
bt: use PSA for HCI ECC and rename BT_TINYCRYPT_ECC
07c2401 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit sets PSA Crypto API as the default library
to perform ECC-DH in HCI, replacing TinyCrypt. Therefore the
symbol BT_TINYCRYPT_ECC is renamed as BT_SEND_ECC_EMULATION.
Rreference in samples/tests are also fixed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti
bt-mesh: remove BT_MESH_USES_TINYCRYPT
2f77ef5 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit removes TinyCrypt usage from BT mesh and
also the related CONFIG_BT_MESH_USES_TINYCRYPT symbol and it sets
PSA Crypto APIs as the default library for crypto operations.
Tests are also updated in this commit.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti
bt: change dependencies for BT_RPA
99933c8 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit modified the dependencies of BT_RPA. Instead
of selecting TinyCrypt, it relies on BT_HOST_CRYPTO or
BT_CTLR_CRYPTO. This helps both in the deprecation process of
TinyCrypt, but also this is more correct dependency since these
2 symbols are extensively used in the rpa.c source code.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti
bt: use PSA for HCI ECC and rename BT_TINYCRYPT_ECC
23662a5 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit sets PSA Crypto API as the default library
to perform ECC-DH in HCI, replacing TinyCrypt. Therefore the
symbol BT_TINYCRYPT_ECC is renamed as BT_SEND_ECC_EMULATION.
Rreference in samples/tests are also fixed.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti
bt-mesh: remove BT_MESH_USES_TINYCRYPT
b0c61a2 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit removes TinyCrypt usage from BT mesh and
also the related CONFIG_BT_MESH_USES_TINYCRYPT symbol and it sets
PSA Crypto APIs as the default library for crypto operations.
Tests are also updated in this commit.

Signed-off-by: Valerio Setti <[email protected]>
valeriosetti added a commit to valeriosetti/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti
bt: change dependencies for BT_RPA
3355dd2 
As part of the deprecation process of TinyCrypt in Zephyr codebase
(zephyrproject-rtos#79566) this commit modified the dependencies of BT_RPA. Instead
of selecting TinyCrypt, it relies on BT_HOST_CRYPTO or
BT_CTLR_CRYPTO. This helps both in the deprecation process of
TinyCrypt, but also this is more correct dependency since these
2 symbols are extensively used in the rpa.c source code.

Signed-off-by: Valerio Setti <[email protected]>
cooked pushed a commit to cooked/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @cooked
drivers: crypto: deprecated TinyCrypt shim driver
50cba2e 
As part of the deprecation process of TinyCrypt started in zephyrproject-rtos#79566,
this commit set the TinyCrypt based crypto shim driver as
deprecated.

Signed-off-by: Valerio Setti <[email protected]>
cooked pushed a commit to cooked/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @cooked
board: remove references to TinyCrypt
fd71433 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove tags
referring to it.

Signed-off-by: Valerio Setti <[email protected]>
cooked pushed a commit to cooked/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @cooked
random: remove TinyCrypt usage
11a0d93 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove
TinyCrypt usage in random generators. This basically only affects
the CTR-DRBG random generator which from now only will only make
use of Mbed TLS.

Signed-off-by: Valerio Setti <[email protected]>
cooked pushed a commit to cooked/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @cooked
jwt: remove TinyCrypt usage
8b13797 
As part of TinyCrypt deprecation process (zephyrproject-rtos#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
andrewnyland pushed a commit to onceLabs/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @andrewnyland
drivers: crypto: deprecated TinyCrypt shim driver
531b027 
As part of the deprecation process of TinyCrypt started in zephyrproject-rtos#79566,
this commit set the TinyCrypt based crypto shim driver as
deprecated.

Signed-off-by: Valerio Setti <[email protected]>
andrewnyland pushed a commit to onceLabs/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @andrewnyland
board: remove references to TinyCrypt
09910eb 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove tags
referring to it.

Signed-off-by: Valerio Setti <[email protected]>
andrewnyland pushed a commit to onceLabs/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @andrewnyland
random: remove TinyCrypt usage
0e6c46f 
Following the deprecation of TinyCrypt (zephyrproject-rtos#79566) we remove
TinyCrypt usage in random generators. This basically only affects
the CTR-DRBG random generator which from now only will only make
use of Mbed TLS.

Signed-off-by: Valerio Setti <[email protected]>
andrewnyland pushed a commit to onceLabs/zephyr that referenced this pull request Nov 6, 2024
@valeriosetti @andrewnyland
jwt: remove TinyCrypt usage
2545b73 
As part of TinyCrypt deprecation process (zephyrproject-rtos#79566) this commit
removes usage of this library from the JWT subsystem and its
related tests.

Signed-off-by: Valerio Setti <[email protected]>
@tomi-font tomi-font mentioned this pull request Nov 7, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomi-font tomi-font tomi-font approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@ceolin ceolin Awaiting requested review from ceolin

@kartben kartben Awaiting requested review from kartben

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

Assignees

@dkalowsk dkalowsk

@mmahadevan108 mmahadevan108

Labels
area: Crypto / RNG Release Notes To be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@valeriosetti @rettichschnidi @ceolin @dkalowsk @tomi-font @carlescufi @mmahadevan108 @zephyrbot