-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the icons for the plex, region, and CICS profile #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @Rajat-Sahrawat - thanks for these! we'll need to get your commits signed (that's the DCO check) - we can work together on that.
i think we should aim to keep them 150px square like the originals - how feasible is it to do that?
Here are some screenshots of what they look like within the GUI:
I think these look good - I like the plex and region icons especially.
@Joe-Winchester might have thoughts too!
on reflection - before asking @Rajat-Sahrawat to fiddle around with the aspect ratios... @JillieBeanSim / @zFernand0 i see you've been requested to review - is there any requirement to stick with square? it appeals to my sense of tidiness, but.... :-) |
3a7d1f3
to
326c5ed
Compare
Signed-off-by: Rajat Sahrawat <[email protected]>
326c5ed
to
6d57aac
Compare
fixed some size issues, signed and updated. @zFernand0 @JillieBeanSim ready for review now |
@zFernand0 @JillieBeanSim Let me know if I need to update the change log for the new icons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new icons look great! 🙏
Thanks @Rajat-Sahrawat
And thanks @davenice for posting pictures of them 🙏
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
=======================================
Coverage 93.17% 93.17%
=======================================
Files 73 73
Lines 718 718
Branches 54 55 +1
=======================================
Hits 669 669
Misses 49 49 ☔ View full report in Codecov by Sentry. |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
6 icons for CICS profile (connected, disconnected, unverified) - light and dark
4 icons for region (connected, disconnected)- light and dark
2 for plex- light and dark