Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the icons for the plex, region, and CICS profile #161

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

Rajat-Sahrawat
Copy link
Contributor

6 icons for CICS profile (connected, disconnected, unverified) - light and dark
4 icons for region (connected, disconnected)- light and dark
2 for plex- light and dark

Copy link
Contributor

@davenice davenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Rajat-Sahrawat - thanks for these! we'll need to get your commits signed (that's the DCO check) - we can work together on that.

i think we should aim to keep them 150px square like the originals - how feasible is it to do that?

Here are some screenshots of what they look like within the GUI:
image

image image

I think these look good - I like the plex and region icons especially.

@Joe-Winchester might have thoughts too!

@davenice
Copy link
Contributor

on reflection - before asking @Rajat-Sahrawat to fiddle around with the aspect ratios... @JillieBeanSim / @zFernand0 i see you've been requested to review - is there any requirement to stick with square? it appeals to my sense of tidiness, but.... :-)

@Rajat-Sahrawat Rajat-Sahrawat force-pushed the icons-for-vs-code branch 3 times, most recently from 3a7d1f3 to 326c5ed Compare December 11, 2024 14:32
@Rajat-Sahrawat
Copy link
Contributor Author

fixed some size issues, signed and updated. @zFernand0 @JillieBeanSim ready for review now

@Rajat-Sahrawat
Copy link
Contributor Author

@zFernand0 @JillieBeanSim Let me know if I need to update the change log for the new icons

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new icons look great! 🙏
Thanks @Rajat-Sahrawat
And thanks @davenice for posting pictures of them 🙏

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (d985dac) to head (1cbd907).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files          73       73           
  Lines         718      718           
  Branches       54       55    +1     
=======================================
  Hits          669      669           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zFernand0 zFernand0 merged commit c16dc0e into zowe:main Dec 12, 2024
13 checks passed
@zFernand0 zFernand0 added the release-patch Indicates a patch to existing code has been applied label Dec 12, 2024
Copy link

Release succeeded for the main branch with some errors. ⚠️

The following packages have been published:

Powered by Octorelease 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-patch Indicates a patch to existing code has been applied released
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants