-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor prescribed messages #576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahkiner
force-pushed
the
refactor-prescribed-messages
branch
from
January 22, 2024 15:01
3c75f95
to
9c72fa8
Compare
schaubh
requested changes
Jan 23, 2024
src/architecture/msgPayloadDefC/PrescribedRotMotionMsgPayload.h
Outdated
Show resolved
Hide resolved
leahkiner
force-pushed
the
refactor-prescribed-messages
branch
from
January 25, 2024 22:44
c599574
to
e165ee6
Compare
leahkiner
force-pushed
the
refactor-prescribed-messages
branch
5 times, most recently
from
February 12, 2024 21:09
62de042
to
6fb482a
Compare
leahkiner
force-pushed
the
refactor-prescribed-messages
branch
from
February 13, 2024 18:24
6fb482a
to
60863fe
Compare
patkenneally
approved these changes
Feb 13, 2024
leahkiner
force-pushed
the
refactor-prescribed-messages
branch
2 times, most recently
from
February 13, 2024 19:29
351baf9
to
aa6275e
Compare
This new message contains only the translational states of a prescribed body relative to a hub-fixed mount frame
This new message contains only the rotational states of a prescribed body relative to a hub-fixed mount frame
The module output message is changed from the prescribedMotionMsgPayload message containing both the translational and rotational states of a prescribed body to only the translational states via the new prescribedTranslationMsgPayload message
The module output message is changed from the prescribedMotionMsgPayload message containing both the translational and rotational states of a prescribed body to only the rotational states via the new prescribedRotationMsgPayload message
The module output message is changed from the prescribedMotionMsgPayload message containing both the translational and rotational states of a prescribed body to only the rotational states via the new prescribedRotationMsgPayload message
The prescribedMotion module is refactored to use the two separate prescribed motion state messages.
leahkiner
force-pushed
the
refactor-prescribed-messages
branch
from
February 13, 2024 19:35
aa6275e
to
7ad731c
Compare
leahkiner
force-pushed
the
refactor-prescribed-messages
branch
from
February 14, 2024 17:23
7ad731c
to
4b186f1
Compare
schaubh
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the single
prescribedMotionMsgPayload
into two separate messages:prescribedTranslationMsgPayload
andprescribedRotationMsgPayload
. This change enables separate kinematic profiler modules to be used to prescribe either the translational or rotational motion of a prescribed body attached to the spacecraft hub.Verification
N/A
Documentation
N/A
Future work
N/A