Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hwdef: Add a new hwdef param for AEROFOX H7 flight control #28533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

hwdef: Add a new hwdef param for AEROFOX H7 flight control #28533

wants to merge 2 commits into from
+396 −1

Conversation

AEROFOXtech
Copy link
Contributor

  1. Add a new flight control board hwdef for AEROFOX_H7
  2. Create a new board ID for AEROFOX_H7 flight control board
  3. Add AEROFOX_H7 bootloader to Tools

andyp1per
andyp1per requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes needed

Tools/AP_Bootloader/board_types.txt Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/defaults.parm Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef-bl.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Show resolved Hide resolved
Hwurzburg
Hwurzburg requested changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs readme ala https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/KakuteH7-Wing/README.md with all info and images

@Hwurzburg
Copy link
Collaborator

@AEROFOXtech I really need each connector's pinout to review...also views of any solder pads/thru holes with their pin labels

Hwurzburg
Hwurzburg requested changes Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add SD card I/O to bootloader code to allow firmware update from SD card
also I have several other review comments requiring changes

libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/README.md Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
@Hwurzburg
Copy link
Collaborator

@AEROFOXtech is this ready for final re-review?you can request in the reviewers box upper right

Hwurzburg
Hwurzburg requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few items missed still

libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/README.md Outdated
- BATT_AMP_PERVL 60

### The power B is external PMU input
- BATT_MONITOR 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still not addressed

libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated Show resolved Hide resolved
@AEROFOXtech AEROFOXtech force-pushed the add_AEROFOX_H7_hwdef branch 2 times, most recently from f963023 to fd81339 Compare November 19, 2024 17:12
Hwurzburg
Hwurzburg requested changes Nov 20, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up to you but we recommend OTG2 be MAVLink2 instead of the default of SLCAN since SLCAN is not as good as using GCS's MAVLink CAN and having SLCAN2 for second USB port can frustrate new users trying to connect a GCS (since it will not on that port)

Also, this PR needs to be two commits....one titled Tools: add AEROFOX H7 bootloaders, with the tools library additions, and on titled hwdef: Add AEROFOX H7

libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Show resolved Hide resolved
Hwurzburg
Hwurzburg requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except for one nit...looks good....
needs @andyp1per approval also

if you have tested, once Andy approve and you disable 2nd batt mon by default, we can mark for devcall and get it merged.....

libraries/AP_HAL_ChibiOS/hwdef/AEROFOX-H7/hwdef.dat Outdated
define HAL_BATT_VOLT_SCALE 21
define HAL_BATT_CURR_SCALE 40

define HAL_BATT2_MONITOR 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably should not enable 2nd monitor by default...just remove line 236

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll make the changes right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laoshen14789 laoshen14789 laoshen14789 left review comments

@Hwurzburg Hwurzburg Hwurzburg approved these changes

@andyp1per andyp1per Awaiting requested review from andyp1per

Assignees
No one assigned
Labels
NewBoardSupport WikiNeeded needs wiki update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AEROFOXtech @Hwurzburg @andyp1per @laoshen14789 @peterbarker