Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hartid: dynamically append hartid #2672

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

Tang-Haojin
Copy link
Member

No description provided.

@Tang-Haojin Tang-Haojin added the do not merge Do not merge this pull request label Jan 24, 2024
@poemonsense
Copy link
Member

Will hartid affect the dedup?

@Tang-Haojin
Copy link
Member Author

Yes. Hartid is hard-encoded in PerfCounter, PerfRolling, ChiselDB, ConstantIn, tp prefetcher, etc., which should be avoided. This PR use dynamic hartid instead, and the verilog-generation time of dual-core is almost the same as that of single-core.

@Tang-Haojin
Copy link
Member Author

With this PR, we can successfully generate 16-core SimTop.v even using chisel 3.
1706234703506
1706234816111

@poemonsense
Copy link
Member

After this PR, dedup is OK? Before this PR, dedup does not work? It seems the hartid is passed by parameter which may cause the dedup to fail?

@poemonsense
Copy link
Member

I'm not sure but it seems from the screenshot it's ok

@Tang-Haojin
Copy link
Member Author

After this PR, dedup is OK? Before this PR, dedup does not work? It seems the hartid is passed by parameter which may cause the dedup to fail?

Yes, and before this PR, dedup dose not work.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 9086a67

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
9086a67 1.878 0.461 2.100 1.209 2.895 2.179 1.397 0.919 1.421 1.123 3.617 2.648 2.302 3.165

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
1fcb3bc 1.878 0.461 2.100 1.211 2.895 2.181 1.395 0.920 1.421 1.123 3.617 2.659 2.302 3.165
f3c16e1 1.878 0.461 2.100 1.213 2.895 2.182 1.396 0.920 1.421 1.126 3.617 2.659 2.302 3.165
45f43e6 1.878 0.461 2.100 1.211 2.895 2.182 1.395 0.920 1.421 1.127 3.617 2.659 2.302 3.165
8fae59b 1.878 0.461 2.100 1.213 2.913 2.182 1.394 0.920 1.421 1.123 3.617 2.647 2.302 3.165
a61a35e 1.879 0.460 2.092 1.200 2.895 2.176 1.394 0.917 1.436 1.125 3.617 2.663 2.298 3.134
14c7c6a 1.881 0.451 2.097 1.194 2.884 2.179 1.390 0.920 1.437 1.126 3.618 2.657 2.293 3.146
2f4a98a 1.874 0.451 2.097 1.196 2.895 2.176 1.389 0.927 1.437 1.125 3.627 2.653 2.292 3.176
032979c 1.874 0.451 2.097 1.202 2.895 2.176 1.386 0.927 1.437 1.125 3.630 2.652 2.300 3.176
ec86549 1.874 0.451 2.097 1.201 2.895 2.176 1.387 0.927 1.437 1.125 3.630 2.650 2.300 3.176
988fb9a 1.874 0.452 2.086 1.197 2.898 2.176 1.385 0.931 1.421 1.127 3.622 2.633 2.281 3.101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Do not merge this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants