-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hartid: dynamically append hartid #2672
base: master
Are you sure you want to change the base?
Conversation
Will hartid affect the dedup? |
Yes. Hartid is hard-encoded in PerfCounter, PerfRolling, ChiselDB, ConstantIn, tp prefetcher, etc., which should be avoided. This PR use dynamic hartid instead, and the verilog-generation time of dual-core is almost the same as that of single-core. |
After this PR, dedup is OK? Before this PR, dedup does not work? It seems the hartid is passed by parameter which may cause the dedup to fail? |
I'm not sure but it seems from the screenshot it's ok |
Yes, and before this PR, dedup dose not work. |
[Generated by IPC robot]
master branch:
|
No description provided.