Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(memblock): opt memset pattern #3632

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

perf(memblock): opt memset pattern #3632

wants to merge 14 commits into from
+403 −61

Conversation

happy-lx
Copy link
Collaborator

@happy-lx happy-lx commented Sep 23, 2024 •
edited
Loading

This PR optimizes the MemSet memory access mode and solves some Sbuffer performance bugs. The specific changes are as follows:

  • The MemSet detection method is changed to: detect whether the delta address and data hash remain constant according to the Store instruction commit order, and the loadQueue is empty.
  • Add an ASP (Accurate Store Prefetcher) prefetcher that works specifically in MemSet mode. It uses different distances according to store instructions of different sizes. The prefetching granularity is currently 1KB.
    • This prefetcher can also relax some restrictions (the data hash remains consistent && loadQueue is empty) to prefetch Store under MemCpy to improve performance. However, in order to prevent other negative impacts, it is only allowed to work under MemSet for now.
  • In order to improve the utilization of Sbuffer under MemSet, try to make the Sbuffer entry completely filled before sending it to Dcache. This will also help Dcache send AcquirePerm instead of AcquireData downwards so that reduce the bus bandwidth.
  • Solve the performance problem of sbuffer enqueuing: set enq.ready when merging is possible.

@happy-lx
perf(sbuffer): fix sbuffer enq ready
86b30b2 
Previously, sbuffer was only ready when there were empty items.
In a scenario where there are no empty items but requests received from sq can be merged,
sbuffer will refuse to receive requests from sq, which will result in failure to run at full throughput.
@happy-lx
perf(sbuffer): opt specially in memset pattern
fcee98f 
If a memset is detected, let each newly allocated sbuffer entry wait for 32 cycles
before writing to the dcache.(When memset and the write bandwidth are full,
at least two sbs are executed in each cycle and 2 bytes are written.
It takes 32 cycles to fill a cacheline)

This will help improve sbuffer utilization
@happy-lx
perf(sq): A more accurate MemSet detection
a7ac43f
@happy-lx
perf(memblock): add ASP store prefetcher
f810f99 
only works in MemSet Pattern
@happy-lx
bump(cpl2): add store prefetch needT
eff67f3
@linjuanZ linjuanZ added the do not merge Do not merge this pull request label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosscharlie bosscharlie bosscharlie approved these changes

@cz4e cz4e Awaiting requested review from cz4e cz4e is a code owner

@linjuanZ linjuanZ Awaiting requested review from linjuanZ linjuanZ is a code owner

@good-circle good-circle Awaiting requested review from good-circle good-circle is a code owner

@cebarobot cebarobot Awaiting requested review from cebarobot cebarobot is a code owner

@Lemover Lemover Awaiting requested review from Lemover Lemover is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
do not merge Do not merge this pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@happy-lx @bosscharlie @linjuanZ