fix(ICache): block waylookup if there is a pending gpf #3719
+21
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing design, ICache assumes that once a gpf occurs, it works on the wrong path until a flush (redirect) arrives, so it can discard redundant gpf/gpaddr data to reduce power/area.
As shown below, the 2nd(orange) and 3rd(blue) gpaddr write to wayLookup is discarded.
This assumption is mostly true, except:
Fix: block writes when there is gpf/gpaddr data in wayLookup that is not read by mainPipe (i.e. is pending).
As shown below, the 1st(yellow) gpaddr write is bypassed to read port, the 2nd is stored in gpf entry, and the 3rd is stalled until the 2nd is read. So all 3 gpaddr data are sent to backend(gpaMem).