Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(MainPipe): remove duplicate signals #4035

Closed
wants to merge 8 commits into from
Closed

style(MainPipe): remove duplicate signals #4035

wants to merge 8 commits into from

Conversation

cz4e
Copy link
Contributor

@cz4e cz4e commented Dec 12, 2024

  • remove mainpipe duplicate signals, wait for timing evaluation.

@cz4e cz4e added the do not merge Do not merge this pull request label Dec 12, 2024
linjuanZ
linjuanZ reviewed Dec 13, 2024
View reviewed changes
Copy link
Member

@linjuanZ linjuanZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please assess timing before this pr is merges.

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: d34e1da

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
d34e1da 1.937 0.451 2.697 1.227 2.866 2.462 2.391 0.930 1.425 2.054 3.437 2.718 2.367 3.210

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
c7ca40e 1.937 0.451 2.697 1.227 2.866 2.462 2.393 0.930 1.425 2.054 3.437 2.718 2.367 3.210
38d0d7c 1.937 0.451 2.697 1.227 2.866 2.462 2.393 0.930 1.425 2.054 3.437 2.718 2.367 3.210
8ffb12e 1.937 0.451 2.697 1.227 2.866 2.462 2.393 0.930 1.425 2.054 3.437 2.718 2.367 3.210
99baa88
f346d72 1.899 0.450 2.701 1.219 2.833 2.461 2.395 0.921 1.426 2.022 3.432 2.707 2.368 3.227

@cz4e cz4e force-pushed the code-mainpipe-dup branch from d34e1da to 7de7706 Compare December 30, 2024 06:04
@cz4e cz4e removed the do not merge Do not merge this pull request label Dec 30, 2024
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 5d41274

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
5d41274 1.814 0.442 2.639 1.231 2.152 2.141 2.361 0.933 1.407 1.985 3.107 2.558 2.267 3.308

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
370a252
9f329f8
7d62bb1 0.933 3.308
c2acf9e 1.814 2.639 1.231 2.152 2.141 2.362 0.933 1.403 1.985 3.107 2.558 2.267 3.308
0aeeba0 1.814 0.442 2.640 1.231 2.152 2.141 2.362 0.933 1.406 1.985 3.107 2.558 2.267 3.308

@cz4e cz4e closed this Jan 2, 2025
@cz4e cz4e deleted the code-mainpipe-dup branch February 19, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linjuanZ linjuanZ linjuanZ left review comments

@happy-lx happy-lx Awaiting requested review from happy-lx happy-lx is a code owner

@bosscharlie bosscharlie Awaiting requested review from bosscharlie bosscharlie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cz4e @XiangShanRobot @linjuanZ