Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

difftest: writeback support for dual core #380

Merged
merged 4 commits into from
May 20, 2024
Merged

difftest: writeback support for dual core #380

merged 4 commits into from
May 20, 2024

Conversation

xiaokamikami
Copy link
Contributor

Multicore support for hasdut added on Paladin or VCS

@poemonsense poemonsense requested a review from klin02 May 20, 2024 03:01
@poemonsense poemonsense merged commit c8897cf into master May 20, 2024
5 checks passed
@poemonsense poemonsense deleted the dual-hasdut branch May 20, 2024 03:11
Copy link

@linkedlist771 linkedlist771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a mix of camelCase (e.g., numPhyRegs, wb_int) and snake_case (e.g., wb_for_skip) naming conventions. To improve consistency and readability, I recommend unifying the naming style throughout the code. In Scala, the generally preferred style for variables and methods is camelCase.

Suggestions:

  • Rename wb_for_skip to wbForSkip.
  • ....

This minor change will help maintain a cohesive code style and make the code easier to understand for future contributors.

@poemonsense
Copy link
Member

I noticed a mix of camelCase (e.g., numPhyRegs, wb_int) and snake_case (e.g., wb_for_skip) naming conventions. To improve consistency and readability, I recommend unifying the naming style throughout the code. In Scala, the generally preferred style for variables and methods is camelCase.

Suggestions:

  • Rename wb_for_skip to wbForSkip.
  • ....

This minor change will help maintain a cohesive code style and make the code easier to understand for future contributors.

I agree with you on the importance of consistent code styles. We prefer to use automated code style checker to ensure the format is consistent. If you have some ideas on this, GitHub Issues/PRs are welcome and much appreciated

@linkedlist771
Copy link

I have created a PR about this issue.😊

xiaokamikami added a commit to xiaokamikami/difftest that referenced this pull request May 30, 2024
Record the writeback according to `coreid`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants