Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporal Component for Topic Landong Page - Parasha and Seasonal Topics #2178

Open
wants to merge 400 commits into
base: topic-landing
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
400 commits
Select commit Hold shift + click to select a range
969ae9b
chore: sheetswithref topic filters update but do not sort or display …
stevekaplan123 Jul 12, 2024
41e17d1
chore: sheetwithref filters and sort options work but filters are not…
stevekaplan123 Jul 12, 2024
c16bae1
feat(Search): SheetsWithRef topics are sorted and update properly bas…
stevekaplan123 Jul 15, 2024
aa5385a
chore: remove duplicates from SheetWithRef filter counts and re-facto…
stevekaplan123 Jul 15, 2024
bc339bd
chore: sheets_with_ref route accepts range param
stevekaplan123 Jul 15, 2024
f2c4ca9
chore: create updateOrigAvailableFilters for SheetsWithRefPage component
stevekaplan123 Jul 15, 2024
3a9511b
chore: remove duplicates from SheetWithRef filter counts and re-facto…
stevekaplan123 Jul 15, 2024
bd90e48
chore: sheets_with_ref route accepts range param
stevekaplan123 Jul 15, 2024
4090e99
chore: duplicates only in topics case not in collections
stevekaplan123 Jul 15, 2024
e602063
Merge branch 'feature/sc-28125/backend-for-sheets-with-ref' into feat…
stevekaplan123 Jul 15, 2024
d2c61b6
chore: started search filtering bug
stevekaplan123 Jul 16, 2024
9c7234b
chore: in process of refactor to ElasticSearchQuerier, ability to cha…
stevekaplan123 Jul 16, 2024
568a3f0
Revert "chore: in process of refactor to ElasticSearchQuerier, abilit…
stevekaplan123 Jul 16, 2024
3550aec
chore: in componentWillReceiveProps for ElasticSearchQuerier reset pa…
stevekaplan123 Jul 16, 2024
8edd476
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Jul 16, 2024
be5b329
chore: pass include_collections to sheets ref api
stevekaplan123 Jul 16, 2024
103570a
Merge branch 'modularization-main' into feature/sc-28105/re-factor-sh…
stevekaplan123 Jul 16, 2024
1691f5f
Merge branch 'modularization-main' into bug/sc-28503/search-filtering…
stevekaplan123 Jul 16, 2024
40b1dbc
chore: remove duplicate slugs for sheetswithref filternodes on fronte…
stevekaplan123 Jul 17, 2024
b4caeb0
Merge branch 'modularization-main' into feature/sc-28027/re-factor-se…
stevekaplan123 Jul 17, 2024
483bc45
Merge branch 'modularization-main' into feature/sc-28105/re-factor-sh…
stevekaplan123 Jul 17, 2024
2a0f337
chore: add loading message to SheetsWithRefPage
stevekaplan123 Jul 17, 2024
d06fc8b
chore: redid searchsheetresult refactor
stevekaplan123 Jul 17, 2024
65792f8
Merge branch 'feature/sc-28027/re-factor-searchresultslist' into feat…
stevekaplan123 Jul 17, 2024
062879f
chore: started removing distinction between textSearchState and sheet…
stevekaplan123 Jul 17, 2024
1c08039
chore: make searchType a ReaderApp state variable
stevekaplan123 Jul 17, 2024
0a6b9a5
chore: use searchState.type instead of searchType
stevekaplan123 Jul 17, 2024
f9b6ccd
feat(Search): removed distinction between textSearchState and sheetSe…
stevekaplan123 Jul 17, 2024
2ae7fd3
chore: default initialSearchType to 'text'
stevekaplan123 Jul 17, 2024
af5628c
chore: change hero banner fonts to sans serif
stevekaplan123 Jul 21, 2024
13d493e
Merge branch 'feature/sc-26951/implement-hero-banner' into feature/sc…
stevekaplan123 Jul 21, 2024
4541f62
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
stevekaplan123 Jul 21, 2024
0e5f69b
chore: filterAggTypes was set to work only for text not sheets
stevekaplan123 Jul 21, 2024
8c26de4
chore: updateAvailableFilters should take type
stevekaplan123 Jul 21, 2024
95496df
chore: searchInCollection should work only in sheets
stevekaplan123 Jul 21, 2024
0480435
chore: remove searchType from panels
stevekaplan123 Jul 21, 2024
4b5c098
chore: dont double count slugs in sheetsWithRef
stevekaplan123 Jul 21, 2024
dc8a620
chore: topics_en becomes topics for sheetswithref
stevekaplan123 Jul 22, 2024
1dc68b9
feat(Sheets with ref): display first comment of sheet if no summary
stevekaplan123 Jul 22, 2024
1d5ea0b
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Jul 22, 2024
0c67f7a
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Jul 22, 2024
2e8cbf9
chore: URL params exist for sheetsWithRef but dont properly set searc…
stevekaplan123 Jul 23, 2024
bccbd88
Merge branch 'modularization-main' into feature/sc-28105/re-factor-sh…
stevekaplan123 Jul 25, 2024
06bf84c
chore(Module switcher): Condense component in header
saengel Jul 25, 2024
57eec93
chore: URL params exist for sheetsWithRef but dont properly set searc…
stevekaplan123 Jul 23, 2024
2481ffa
chore: update total results on filter
stevekaplan123 Jul 28, 2024
257f707
feat(Sheets with Ref): URL filter params working
stevekaplan123 Jul 28, 2024
6e838eb
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Jul 28, 2024
edd9c86
Merge branch 'bug/sc-28503/search-filtering-bug-for-sheets' into feat…
stevekaplan123 Jul 28, 2024
3e7837f
chore: remove sheetSearchState and replace with searchState
stevekaplan123 Jul 28, 2024
51fbd26
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
stevekaplan123 Jul 28, 2024
d2b75a1
Merge branch 'modularization-main' into feature/sc-26957/sidebar-with…
stevekaplan123 Jul 28, 2024
3bdff23
chore(Module Switcher): Rework css
saengel Jul 28, 2024
9e2e7af
Merge branch 'modularization-main' into feature/sc-28027/re-factor-se…
stevekaplan123 Jul 29, 2024
302c95e
chore: remove unnecessary fields
stevekaplan123 Jul 29, 2024
8741ea7
Merge branch 'feature/sc-28027/re-factor-searchresultslist' into feat…
stevekaplan123 Jul 29, 2024
ca9e752
fix(Sheets with ref): firefox vs chrome sorted filters differently
stevekaplan123 Jul 29, 2024
a3f249b
chore: use normRef to deal with ranges when loading route for sheetsW…
stevekaplan123 Jul 29, 2024
7cc3057
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Jul 29, 2024
5bab144
chore: change wordSelected to sortFiltersBySelected
stevekaplan123 Jul 29, 2024
067bb27
chore(Module Switcher): Finish refining css
saengel Jul 30, 2024
f0867ec
Merge branch 'modularization-main' into feature/sc-27518/backend-for-…
stevekaplan123 Jul 31, 2024
2be7154
chore: remove irrelevant file
stevekaplan123 Jul 31, 2024
97fb3f9
chore: update hero banner font weight
stevekaplan123 Jul 31, 2024
fb1c49e
chore: start parasha_data_api
stevekaplan123 Aug 1, 2024
80c455e
chore: double parshiyot can be handled exactly the same way as regula…
stevekaplan123 Aug 1, 2024
740b1ef
Merge branch 'feature/sc-27518/backend-for-sheets-topics-component' i…
stevekaplan123 Aug 1, 2024
21b9a97
chore: getCurrentParasha in sefaria.js
stevekaplan123 Aug 1, 2024
c71f1f6
Merge branch 'modularization-main' into feature/sc-26951/implement-he…
stevekaplan123 Aug 4, 2024
aa52e8b
Merge branch 'modularization-main' into feature/sc-27518/backend-for-…
stevekaplan123 Aug 4, 2024
567c185
chore(Module Switcher): Merge in modularization-main
saengel Aug 4, 2024
571d4e9
Merge branch 'modularization-main' into feature/sc-26957/sidebar-with…
stevekaplan123 Aug 5, 2024
d6a9598
Merge branch 'modularization-main' into feature/sc-28027/re-factor-se…
stevekaplan123 Aug 5, 2024
8f51c98
chore: make URL routes clearer and dont return jsonResponse from find…
stevekaplan123 Aug 5, 2024
2d0566a
Merge branch 'feature/sc-27518/backend-for-sheets-topics-component' i…
stevekaplan123 Aug 5, 2024
f394c8a
chore: use proper api routes for getNextHoliday and getCurrentParasha
stevekaplan123 Aug 5, 2024
33fb2d0
Merge branch 'feature/sc-26951/implement-hero-banner' into feature/sc…
stevekaplan123 Aug 5, 2024
a9c343d
Merge pull request #1936 from Sefaria/feature/sc-26679/implement-modu…
saengel Aug 5, 2024
5653de6
Merge pull request #1943 from Sefaria/feature/sc-28027/re-factor-sear…
stevekaplan123 Aug 5, 2024
beb2f90
Merge pull request #1917 from Sefaria/feature/sc-26951/implement-hero…
stevekaplan123 Aug 5, 2024
a56d01e
Merge pull request #1916 from Sefaria/feature/sc-27518/backend-for-sh…
stevekaplan123 Aug 6, 2024
022e1d0
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
stevekaplan123 Aug 6, 2024
d7c6da7
Merge branch 'modularization-main' into feature/sc-26957/sidebar-with…
stevekaplan123 Aug 6, 2024
5bb342e
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Aug 6, 2024
8217caa
chore: remove unnecessary duplicate file
stevekaplan123 Aug 6, 2024
97dbecf
chore: deleted unnecessary sheets file
stevekaplan123 Aug 6, 2024
71f05c3
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Aug 6, 2024
404aade
chore: undo sheets.html change
stevekaplan123 Aug 6, 2024
fd0c398
chore: return None not null
stevekaplan123 Aug 6, 2024
e75b36c
Merge branch 'modularization-main' into feature/sc-27901/card-box-com…
stevekaplan123 Aug 6, 2024
d3fd367
Merge branch 'feature/sc-27901/card-box-component' into feature/sc-26…
stevekaplan123 Aug 6, 2024
5484b4b
chore: Undo remove Button from GenericComponents
stevekaplan123 Aug 6, 2024
a0c2735
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Aug 6, 2024
d633b47
chore: fix awkward spacing in TopicsPage.jsx
stevekaplan123 Aug 6, 2024
d9ddae3
chore: refactor SheetsTopics to use Sefaria.getUpcomingDay
stevekaplan123 Aug 6, 2024
3357c42
chore: dont use first comment in source sheet when there is no sheet …
stevekaplan123 Aug 6, 2024
60413f5
feat(secondary nav): First pass at logged out menu
saengel Aug 6, 2024
af7e0c5
chore(secondary nav): Small tweaks to generic component to enable mor…
saengel Aug 6, 2024
ae5f2e8
Merge branch 'modularization-main' into feature/sc-28105/re-factor-sh…
stevekaplan123 Aug 7, 2024
b6e493c
chore: refactor get_collections_for_sheets
stevekaplan123 Aug 7, 2024
de449d8
chore: refactor topic querying functions into class TopicQuerier
stevekaplan123 Aug 7, 2024
8dcf62c
chore: refactor sheetsWithRefFilterNodes
stevekaplan123 Aug 7, 2024
7ed599f
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Aug 7, 2024
56d404f
chore: fix bad merge
stevekaplan123 Aug 7, 2024
4382f09
feat(secondary nav): Additional functionality, placeholder for langua…
saengel Aug 7, 2024
d65cc30
feat(secondary nav): Working language toggle implementation, first pa…
saengel Aug 7, 2024
6cc6de1
chore(secondary nav): Remove unused prop
saengel Aug 7, 2024
607c67a
chore: remove relevance as an option for sheets with ref
stevekaplan123 Aug 11, 2024
287d8ba
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Aug 11, 2024
febb11d
chore: merge bugs in sheets with ref
stevekaplan123 Aug 11, 2024
12baaba
feat(secondary nav): logged out language style fixes
saengel Aug 11, 2024
0c89a79
chore: minor changes to sheets with ref
stevekaplan123 Aug 12, 2024
2c4a60a
fix(Sheets with Ref): reset search filters on unmount
stevekaplan123 Aug 12, 2024
4d6ee9e
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Aug 12, 2024
437bc32
chore: refactor sheets with refs so that we never update origAvailabl…
stevekaplan123 Aug 12, 2024
04c1474
feat(secondary nav): css clean up, dot via pseudoclass
saengel Aug 12, 2024
f0f83f3
chore: dont update filter doc count unless its aggType is the right type
stevekaplan123 Aug 14, 2024
191cae1
chore: remove comment
stevekaplan123 Aug 14, 2024
44978c1
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Aug 14, 2024
a81d6cb
chore: rename GenericComponents to Card
stevekaplan123 Aug 14, 2024
ee320ea
chore: move buttons to NavSidebar
stevekaplan123 Aug 14, 2024
d86f96a
Merge branch 'feature/sc-27901/card-box-component' into feature/sc-26…
stevekaplan123 Aug 14, 2024
61420d2
chore: cleanup files for PR
stevekaplan123 Aug 14, 2024
baf852f
chore: refactor CreateASheet and WhatIsASourceSheet with TitledText
stevekaplan123 Aug 14, 2024
c866563
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Aug 14, 2024
45dff42
chore: cleanup after merge
stevekaplan123 Aug 14, 2024
af8dfff
chore: css changes for Cards
stevekaplan123 Aug 15, 2024
60bd557
chore: css for Cards
stevekaplan123 Aug 15, 2024
6a42bff
Merge branch 'feature/sc-27901/card-box-component' into feature/sc-26…
stevekaplan123 Aug 15, 2024
2f08000
Merge branch 'feature/sc-27901/card-box-component' into feature/sc-26…
stevekaplan123 Aug 15, 2024
24af0dd
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Aug 15, 2024
192de4b
chore: cleanup unnecessary changes
stevekaplan123 Aug 15, 2024
9475e91
chore: cleanup misc jsx line
stevekaplan123 Aug 15, 2024
f45a5bb
Revert "chore: cleanup misc jsx line"
stevekaplan123 Aug 15, 2024
1d39fea
chore: cleanup misc jsx
stevekaplan123 Aug 15, 2024
0eb1c74
chore: sheetsWithRef should not be passed to Sefaria module but rathe…
stevekaplan123 Aug 15, 2024
005bc87
chore: fix makehistorystate for sheetswithref
stevekaplan123 Aug 15, 2024
c05a1ea
feat(secondary nav): Align hebrew and english text
saengel Aug 15, 2024
1b18449
feat(secondary nav): fix spacing
saengel Aug 15, 2024
5fa14d5
chore: fix spacing in SearchPage
stevekaplan123 Aug 18, 2024
43a3292
Merge remote-tracking branch 'origin/master' into modularization-main
edamboritz Aug 18, 2024
f7725dd
chore(secondary nav): revert accidental added space
saengel Aug 18, 2024
048f2e8
Merge branch 'modularization-main' into feature/sc-28105/re-factor-sh…
stevekaplan123 Aug 19, 2024
5f7b040
Merge branch 'feature/sc-28105/re-factor-sheetsearchfilters-to-work-f…
stevekaplan123 Aug 19, 2024
044cbf1
chore: fix bad merge
stevekaplan123 Aug 19, 2024
974ef6c
Merge pull request #1971 from Sefaria/feature/sc-28105/re-factor-shee…
stevekaplan123 Aug 20, 2024
096ed16
Merge branch 'modularization-main' into feature/sc-28127/frontend-for…
stevekaplan123 Aug 21, 2024
db4dc8d
Merge branch 'modularization-main' into bug/sc-28503/search-filtering…
stevekaplan123 Aug 21, 2024
e3c62db
chore: undo unnecessary merge additions
stevekaplan123 Aug 21, 2024
3c7d939
chore: syntax fix in SearchPage
stevekaplan123 Aug 21, 2024
5cd5a23
Merge pull request #1966 from Sefaria/topic-backend
YishaiGlasner Aug 21, 2024
5247959
feat(secondary nav): mobile library logged in first pass
saengel Aug 21, 2024
787c8f9
feat(secondary nav): first pass modularization logged out menu
saengel Aug 21, 2024
3eedf87
feat(secondary nav): adjustments to products positions
saengel Aug 21, 2024
e38a5b7
feat(secondary nav): mobile module switcher icons
saengel Aug 21, 2024
e1917f0
chore: remove nav sidebar module JoinTheConversation
stevekaplan123 Aug 26, 2024
628e31d
Merge pull request #2014 from Sefaria/feature/sc-26853/remove-join-th…
stevekaplan123 Aug 27, 2024
fb408f8
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
stevekaplan123 Aug 29, 2024
0ec0945
Merge branch 'master' into modularization-main
stevekaplan123 Sep 3, 2024
30515ea
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
stevekaplan123 Sep 3, 2024
138b8f6
chore: comment
stevekaplan123 Sep 3, 2024
c7655df
Merge remote-tracking branch 'origin/master' into modularization-main
edamboritz Sep 3, 2024
969cd9a
Merge branch 'modularization-main' into feature/sc-26957/sidebar-with…
stevekaplan123 Sep 3, 2024
6cf480a
chore: modify spelling
stevekaplan123 Sep 3, 2024
4f84065
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Sep 3, 2024
8e61075
Merge branch 'modularization-main' into feature/sc-27901/card-box-com…
stevekaplan123 Sep 3, 2024
4a4523f
Merge branch 'modularization-main' of https://github.com/Sefaria/Sefa…
stevekaplan123 Sep 4, 2024
16a389c
Merge branch 'modularization-main' into feature/sc-26957/sidebar-with…
stevekaplan123 Sep 4, 2024
6b998a2
Merge branch 'modularization-main' into feature/sc-27901/card-box-com…
stevekaplan123 Sep 4, 2024
241a630
Merge branch 'feature/sc-27901/card-box-component' into feature/sc-26…
stevekaplan123 Sep 5, 2024
ceb966f
Merge pull request #2005 from Sefaria/bug/sc-28503/search-filtering-b…
stevekaplan123 Sep 8, 2024
e9096a2
Merge branch 'modularization-main' into feature/sc-28127/frontend-for…
stevekaplan123 Sep 9, 2024
9d6b15c
chore: field should be None for get_search_params when tab is sheet
stevekaplan123 Sep 9, 2024
6409ba4
Merge branch 'modularization-main' of https://github.com/Sefaria/Sefa…
stevekaplan123 Sep 9, 2024
6091ad4
Merge branch 'modularization-main' into feature/sc-28127/frontend-for…
stevekaplan123 Sep 9, 2024
5563654
Merge pull request #1982 from Sefaria/feature/sc-28127/frontend-for-s…
stevekaplan123 Sep 9, 2024
486330f
Merge branch 'modularization-main' into feature/sc-27901/card-box-com…
stevekaplan123 Sep 9, 2024
954d03d
Merge pull request #1924 from Sefaria/feature/sc-27901/card-box-compo…
stevekaplan123 Sep 9, 2024
2bbe5d1
chore: refactor ModuleTitle so that h1 is always used
stevekaplan123 Sep 9, 2024
b6ea9ec
chore: modify CSS for readerNavCategoryMenu
stevekaplan123 Sep 9, 2024
33287aa
Merge pull request #2031 from Sefaria/feature/sc-29223/re-factor-modu…
stevekaplan123 Sep 9, 2024
4b8ce9b
Merge branch 'modularization-main' into feature/sc-26957/sidebar-with…
stevekaplan123 Sep 9, 2024
6dbfbe4
feat(secondary nav): Add lines according to spec
saengel Sep 9, 2024
10cf357
chore: refactor TitledText to not have h1Header
stevekaplan123 Sep 9, 2024
341f735
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Sep 9, 2024
af35618
feat(secondary nav): adjust signup/login, attempt to add dot
saengel Sep 9, 2024
97ffd3c
feat(secondary nav): fix alignment of sign up buttons
saengel Sep 10, 2024
cc8e798
feat(secondary nav): update products icon
saengel Sep 10, 2024
def021b
feat(secondary nav): polish to the Hebrew
saengel Sep 10, 2024
89cc045
feat(secondary nav): new products icon, all products in hamburger menu
saengel Sep 10, 2024
46f0029
feat(secondary nav): Hebrew tweaks
saengel Sep 10, 2024
fd59e48
chore(secondary nav): hebrew tweaks part two
saengel Sep 10, 2024
4667f22
feat(secondary nav): Shift from explore to topics
saengel Sep 10, 2024
4192680
chore: refactor to use new Button component
stevekaplan123 Sep 12, 2024
ebe35d8
chore: make sheets homepage css clearer
stevekaplan123 Sep 12, 2024
cd6f54d
chore: only put a line above a card on sheetshomepage so that it look…
stevekaplan123 Sep 12, 2024
c0c3f89
chore: remove shadow for hero banner text
stevekaplan123 Sep 12, 2024
e3954c3
chore: move to single panel at 840 instead of 800 or 600
stevekaplan123 Sep 12, 2024
e015633
chore: use contentInner to style sheetsTopics to make it look like te…
stevekaplan123 Sep 17, 2024
743c076
chore: use img instead of Icon
stevekaplan123 Sep 17, 2024
a658516
chore: sheetsHomepage instead of sheets
stevekaplan123 Sep 17, 2024
3b230c1
Merge branch 'feature/sc-26957/sidebar-with-create-a-sheet-and-educat…
stevekaplan123 Sep 17, 2024
c3ced8f
chore: create 4 states of screen width
stevekaplan123 Sep 19, 2024
ca594bd
chore: fix spelling in reader panel of sheets directory
stevekaplan123 Sep 22, 2024
8d99073
Merge pull request #2048 from Sefaria/change-spelling-sheets-directories
stevekaplan123 Sep 22, 2024
7800422
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
stevekaplan123 Sep 25, 2024
f7d2e13
Merge branch 'modularization-main' into feature/sc-26957/sidebar-with…
stevekaplan123 Sep 25, 2024
e75e417
Merge pull request #1994 from Sefaria/feature/sc-26957/sidebar-with-c…
stevekaplan123 Sep 25, 2024
76632ba
Merge pull request #2000 from Sefaria/feature/sc-27511/library-add-us…
saengel Sep 25, 2024
db0e7b3
Merge pull request #1952 from Sefaria/feature/sc-26824/remove-existin…
saengel Sep 25, 2024
97fc0ae
chore: general solution to 4 screen states using class table
stevekaplan123 Sep 26, 2024
6b3e9f3
chore: fix navsidebar's margin top in sheets homepage
stevekaplan123 Sep 26, 2024
f865527
chore: explicitly use table class for above 900 and between 600 and 700
stevekaplan123 Sep 30, 2024
9fb6b96
chore: sheets URL should be able to have / appended to it
stevekaplan123 Oct 1, 2024
f0af4ea
chore: cleanup card css in sheets homepage
stevekaplan123 Oct 1, 2024
fa3dcf8
chore: use clearer syntax for nth child pseudochild
stevekaplan123 Oct 1, 2024
9a9df2f
Merge remote-tracking branch 'origin/master' into modularization-main
edamboritz Oct 1, 2024
8456ee5
Merge pull request #2032 from Sefaria/feature/sc-27514/library-user-m…
saengel Oct 6, 2024
91e16ea
Merge pull request #1937 from Sefaria/feature/sc-26806/removal-of-com…
saengel Oct 7, 2024
c6499f9
Merge branch 'modularization-main' into feature/sc-26953/frontend-for…
stevekaplan123 Oct 8, 2024
7019aff
Merge pull request #1928 from Sefaria/feature/sc-26953/frontend-for-s…
akiva10b Oct 8, 2024
e1e4cf0
feat(secondary nav): merge in modularization-main
saengel Oct 8, 2024
c23239d
chore: move files in shared directory to common and delete shared dir
stevekaplan123 Oct 29, 2024
9d7348d
Merge pull request #2082 from Sefaria/rename-shared-to-common
stevekaplan123 Oct 29, 2024
af6de49
chore: changed directory from shared to common but forgot to change t…
stevekaplan123 Nov 7, 2024
9f88379
Merge pull request #2101 from Sefaria/shared-to-common
yitzhakc Nov 7, 2024
8f6e475
Merge pull request #2008 from Sefaria/feature/sc-27517/library-user-m…
saengel Nov 10, 2024
86a651c
chore(footer): Merge in modularization-main, resolve conflicts
saengel Nov 11, 2024
a7b52df
Merge pull request #1946 from Sefaria/feature/sc-26817/design-and-imp…
saengel Nov 11, 2024
86a73a5
chore: merge
nsantacruz Dec 2, 2024
eb1d725
Merge pull request #2139 from Sefaria/pull-out-image-cropper
nsantacruz Dec 3, 2024
8da4e5d
merge(Temporal Card): merge card and backend temporal utils from modu…
yonadavGit Dec 8, 2024
13acd75
feat(Topic Landing Calendar): skeleton of new Calendar component
yonadavGit Dec 8, 2024
e58d0bb
feat(Topic Landing Calendar): style header of calendar component
yonadavGit Dec 9, 2024
90ec6eb
feat(Topic Landing Temporal): skeleton of TopicLandingParasha
yonadavGit Dec 9, 2024
c7f03e1
feat(Topic Landing Temporal): children of TopicLandingParasha
yonadavGit Dec 9, 2024
bbe6496
feat(Topic Landing Temporal): seasonal topic api endpoint
yonadavGit Dec 9, 2024
c4b36a3
feat(Topic Landing Temporal): skeleton of TopicLandingSeasonal
yonadavGit Dec 9, 2024
34b70bf
feat(Topic Landing Temporal): style temporal components
yonadavGit Dec 10, 2024
28ab9cd
feat(Topic Landing Temporal): added element to temporal components
yonadavGit Dec 10, 2024
5655ba6
feat(Topic Landing Temporal): get display date and message from serve…
yonadavGit Dec 11, 2024
5749fb7
feat(Topic Landing Temporal): merge master
yonadavGit Dec 11, 2024
e579f0b
chore(Topic Landing Temporal): fix merge conflicts
yonadavGit Dec 11, 2024
86675cb
feat(Topic Landing Temporal): fix turn display date message into a li…
yonadavGit Dec 12, 2024
8bff332
refactor(Topic Landing Temporal): export date retrieval into a custom…
yonadavGit Dec 12, 2024
eae74df
feat(Topic Landing Temporal): Hebrew localization
yonadavGit Dec 12, 2024
c5378fc
feat(Topic Landing Temporal): replace > with caret
yonadavGit Dec 12, 2024
8a229fd
feat(Topic Landing Temporal): space before caret
yonadavGit Dec 12, 2024
fd014c2
feat(Topic Landing Temporal): only topic title is a-tagged
yonadavGit Dec 12, 2024
46ea310
fix(Topic Landing Temporal): only return all necessary variables in hook
yonadavGit Dec 12, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat(secondary nav): Working language toggle implementation, first pa…
…ss through
saengel committed Aug 7, 2024
commit d65cc3038ec7511d8f1ec09ee307cb849a9108ff
57 changes: 32 additions & 25 deletions static/js/Header.jsx
Original file line number Diff line number Diff line change
@@ -18,44 +18,53 @@ import {Autocomplete} from './Autocomplete'
import { DropdownMenu, DropdownMenuSeparator, DropdownMenuItem, DropdownMenuItemWithIcon } from './common/DropdownMenu';


const LoggedOutMenu = (curLang, transLangPreference, setTransLangPreference) => {
const LoggedOutMenu = (currentLang) => {
const [isClient, setIsClient] = useState(false);
const [next, setNext] = useState("/");
const [loginLink, setLoginLink] = useState("/login?next=/");
const [registerLink, setRegisterLink] = useState("/register?next=/");

useEffect(()=>{
setIsClient(true);
}, []);

useEffect(()=> {
if(isClient){
setNext(encodeURIComponent(Sefaria.util.currentPath()));
setLoginLink("/login?next="+next);
setRegisterLink("/register?next="+next);
}
})

const getCurrentPage = () => {
return encodeURIComponent(Sefaria.util.currentPath());
}
return (
<DropdownMenu menu_icon={'/static/icons/logged_out.svg'}>
<DropdownMenuItem url={loginLink}>
Log in
</DropdownMenuItem>
<DropdownMenuItem url={registerLink}>
Sign up
</DropdownMenuItem>
<DropdownMenuSeparator />
<DropdownMenuItem>
Language toggle goes here
</DropdownMenuItem>
{/* <InterfaceLanguageMenu
currentLang={curLang}
translationLanguagePreference={transLangPreference}
setTranslationLanguagePreference={setTransLangPreference} /> */}
<DropdownMenuSeparator />
<DropdownMenuItem url={'/updates'}>
New additions
</DropdownMenuItem>
<DropdownMenuItem url={'/help'}>
Help
</DropdownMenuItem>
<DropdownMenuItem url={loginLink}>
Log in
</DropdownMenuItem>
<DropdownMenuItem url={registerLink}>
Sign up
</DropdownMenuItem>
<DropdownMenuSeparator />
<div className="interfaceLinks-header">
<InterfaceText>Site Language</InterfaceText>
</div>
<DropdownMenuItem url={`/interface/hebrew?next=${getCurrentPage()}`}>
עברית
</DropdownMenuItem>
<DropdownMenuItem url={`/interface/english?next=${getCurrentPage()}`}>
English
</DropdownMenuItem>
<DropdownMenuSeparator />
<DropdownMenuItem url={'/updates'}>
New additions
</DropdownMenuItem>
<DropdownMenuItem url={'/help'}>
Help
</DropdownMenuItem>

</DropdownMenu>
);
}
@@ -141,9 +150,7 @@ class Header extends Component {

{ Sefaria._uid ?
<LoggedInButtons headerMode={this.props.headerMode}/>
: <LoggedOutMenu curLang={Sefaria.interfaceLang}
transLangPreference={this.props.translationLanguagePreference}
setTransLangPreference={this.props.setTranslationLanguagePreference}/>
: <LoggedOutMenu currentLang={Sefaria.interfaceLang}/>
}

</div>