Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and comply with ruff linter #1065

Merged
merged 12 commits into from
Dec 27, 2024
Merged

Enable and comply with ruff linter #1065

merged 12 commits into from
Dec 27, 2024

Conversation

cgokmen
Copy link
Contributor

@cgokmen cgokmen commented Dec 27, 2024

Switches us from black and isort to ruff, which is a combined linter and formatter. For now, this PR enables just the default checks, including unused imports and variables, star imports, __all__ statements etc. - already caught at least 3-4 bugs just while fixing the linter results. Later on we can continue enabling more features as we go.

@cgokmen cgokmen requested a review from cremebrule December 27, 2024 05:47
@cgokmen cgokmen merged commit 260704c into og-develop Dec 27, 2024
21 of 22 checks passed
@cgokmen cgokmen deleted the ruff branch December 27, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants