Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the IK Solver acccording to the lula update in 2023.1.0 #299

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Update the IK Solver acccording to the lula update in 2023.1.0 #299

merged 3 commits into from
Oct 26, 2023

Conversation

mj-hwang
Copy link
Contributor

Update the IK Solver in accordance with the lula update in 2023.1.0

cremebrule
cremebrule approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@cremebrule cremebrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! this has been validated with our current examples, right? (e.g.: robot_control_example)?

@mj-hwang
Copy link
Contributor Author

Yes! They are validated with our testing scripts. I also added a support for older versions of Isaac (per Cem's recommendation).

@cremebrule
Copy link
Contributor

lgtm!

wensi-ai
wensi-ai reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@wensi-ai wensi-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we merge this? I'd like to use it with my VR stuff

@cgokmen
Copy link
Contributor

cgokmen commented Oct 26, 2023

I'm going ahead and merging this.

@cgokmen cgokmen merged commit 83cef8c into og-develop Oct 26, 2023
2 of 3 checks passed
@cgokmen cgokmen deleted the ik_solver_fix_2023_1 branch October 26, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wensi-ai wensi-ai wensi-ai left review comments

@cremebrule cremebrule cremebrule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mj-hwang @cremebrule @cgokmen @wensi-ai