Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace dynamic control APIs with Isaac.Core View APIs #336

Merged
merged 79 commits into from
Dec 21, 2023
Merged

Replace dynamic control APIs with Isaac.Core View APIs #336

merged 79 commits into from
Dec 21, 2023

Conversation

cgokmen
Copy link
Contributor

@cgokmen cgokmen commented Dec 11, 2023

No description provided.

@cgokmen cgokmen requested a review from cremebrule December 11, 2023 04:29
@cgokmen cgokmen requested a review from ChengshuLi December 12, 2023 03:50
ChengshuLi
ChengshuLi reviewed Dec 12, 2023
View reviewed changes
omnigibson/prims/entity_prim.py Show resolved Hide resolved
omnigibson/prims/entity_prim.py Show resolved Hide resolved
omnigibson/prims/entity_prim.py Outdated Show resolved Hide resolved
omnigibson/prims/joint_prim.py Outdated Show resolved Hide resolved
omnigibson/prims/joint_prim.py Outdated Show resolved Hide resolved
omnigibson/utils/extended_articulation_view.py Outdated Show resolved Hide resolved
omnigibson/utils/extended_articulation_view.py Outdated Show resolved Hide resolved
omnigibson/utils/extended_articulation_view.py Outdated Show resolved Hide resolved
omnigibson/utils/extended_articulation_view.py Outdated Show resolved Hide resolved
omnigibson/utils/extended_articulation_view.py Outdated Show resolved Hide resolved
@cremebrule cremebrule self-requested a review December 21, 2023 06:06
cremebrule
cremebrule approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@cremebrule cremebrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall LGTM!! Just some minor clarifying questions overall, once addressed, feel free to merge

ChengshuLi
ChengshuLi approved these changes Dec 21, 2023
View reviewed changes
omnigibson/objects/dataset_object.py Show resolved Hide resolved
omnigibson/objects/object_base.py Show resolved Hide resolved
omnigibson/objects/primitive_object.py Show resolved Hide resolved
omnigibson/objects/stateful_object.py Show resolved Hide resolved
omnigibson/objects/usd_object.py Show resolved Hide resolved
omnigibson/prims/rigid_prim.py Show resolved Hide resolved
omnigibson/prims/entity_prim.py Outdated Show resolved Hide resolved
@cgokmen
Copy link
Contributor Author

cgokmen commented Dec 21, 2023

Many thanks for the reviews. Merging.

@cgokmen cgokmen merged commit 08aee08 into og-develop Dec 21, 2023
2 of 3 checks passed
@cgokmen cgokmen deleted the articulationview branch December 21, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cremebrule cremebrule cremebrule approved these changes

@ChengshuLi ChengshuLi ChengshuLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgokmen @ChengshuLi @cremebrule