Fix some bugs in cloth generation #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Switch to ClothPrimView and fix some bugs in cloth generation" This reverts commit a4f865b. Revert "Revert "Switch to ClothPrimView and fix some bugs in cloth generation"" This reverts commit ed5d8b9b72a8fdb6766ce98e3141adaeb79fb991.
ChengshuLi
reviewed
Dec 12, 2023
|
I have tested this and confirmed the cloth demos still work. |
cremebrule
reviewed
Dec 13, 2023
cremebrule
reviewed
Dec 13, 2023
cremebrule
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caps the max particle count to something we'll need to upper bound by later (due to GPU stuff), and also fixes an issue that causes each vertex to appear 6 times in the final mesh.