Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for missing test xml #913

Merged
merged 6 commits into from
Oct 4, 2024
Merged

Check for missing test xml #913

merged 6 commits into from
Oct 4, 2024

Conversation

hang-yin
Copy link
Contributor

No description provided.

@hang-yin hang-yin requested a review from cgokmen September 27, 2024 22:34
@hang-yin hang-yin marked this pull request as ready for review September 27, 2024 22:34
@cgokmen cgokmen added this to the v1.2.0 milestone Oct 1, 2024
@hang-yin hang-yin self-assigned this Oct 2, 2024
@cgokmen cgokmen linked an issue Oct 4, 2024 that may be closed by this pull request
Fix segfault-failing tests not getting picked up as failing checks in report #912
Open
cgokmen
cgokmen approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@cgokmen cgokmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt fully fix the issue, but is a good start

@cgokmen cgokmen merged commit 6a56272 into og-develop Oct 4, 2024
1 of 2 checks passed
@cgokmen cgokmen deleted the fix/report-missing-xml branch October 4, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgokmen cgokmen cgokmen approved these changes

Assignees

@hang-yin hang-yin

Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Fix segfault-failing tests not getting picked up as failing checks in report
2 participants
@hang-yin @cgokmen