Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing rename behavior in old glibc versions #927

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fix missing rename behavior in old glibc versions #927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67f53f1
Fix missing rename behavior in old glibc versions
cgokmen Oct 2, 2024
5211bd1
Actually fix it
cgokmen Oct 2, 2024
4cdbb33
Add no install datasets flag
cgokmen Oct 2, 2024
15aacc5
Unfold argument documentation
cgokmen Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/getting_started/installation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ There are three ways to setup **`OmniGibson`**, all built upon different ways of

3. Run the installation script to install Isaac Sim as well as **`OmniGibson`** dataset and assets:

```{.shell .annotate}
python -m omnigibson.install # (1)!
```shell
python -m omnigibson.install
```

1. You can apply additional flag `--no-install-datasets` to skip dataset install.
You can apply additional flag `--no-install-datasets` to skip dataset install.

If this step fails, we recommend considering the [source installation](#__tabbed_1_3) method.

Expand Down Expand Up @@ -207,11 +207,11 @@ There are three ways to setup **`OmniGibson`**, all built upon different ways of

4. Run the installation script to hook the environment up to Isaac Sim as well as **`OmniGibson`** dataset and assets:

```{.shell .annotate}
python -m omnigibson.install --launcher-install # (1)!
```shell
python -m omnigibson.install --launcher-install
```

1. You can specify your Isaac Sim install location using the argument `--isaac-sim-path` if it differs from the default. You can also apply additional flag `--no-install-datasets` to skip dataset install.
You can specify your Isaac Sim install location using the argument `--isaac-sim-path` if it differs from the default. You can also apply additional flag `--no-install-datasets` to skip dataset install.

!!! note "What does this do?"

Expand Down
11 changes: 9 additions & 2 deletions omnigibson/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,13 @@ def _rename_if_necessary(filename: Path):
This is permissible because the manylinux wheels are compatible with older GLIBC versions even though
the filename suggests not - so we apply this hacky workaround. This allows pip to try to install them.
"""
# Rename the file if the system's GLIBC version is older than the one used in the NVIDIA PyPI packages
if platform.system() == "Linux" and _is_glibc_older():
return filename.with_name(filename.name.replace("manylinux_2_34", "manylinux_2_31"))
new_filename = filename.with_name(filename.name.replace("manylinux_2_34", "manylinux_2_31"))
shutil.move(filename, new_filename)
return new_filename

# If the file is not renamed, return the original filename
return filename


Expand Down Expand Up @@ -278,7 +283,9 @@ def attempt_pip_install():

@click.command()
@click.option(
"--install-datasets", default=True, help="Install the OmniGibson dataset and assets after installing Isaac Sim"
"--install-datasets/--no-install-datasets",
default=True,
help="Install the OmniGibson dataset and assets after installing Isaac Sim",
)
@click.option(
"--launcher-install/--pip-install",
Expand Down
Loading