Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Key Array Caching #962

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Fix Key Array Caching #962

merged 5 commits into from
Oct 24, 2024

Conversation

hang-yin
Copy link
Contributor

Thanks to @MhdMohammadi for reporting this.

Problem

In instance segmentation, Replicator occasionally mislabels some objects as unlabelled in the info dict despite having distinct labels for them in the segmentation map. This typically occurs when only a small portion (a few pixels) of an object is visible.

The issue impacts our key array caching in segmentation remapping:

  1. We only update the key array when new labels appear.
  2. We don't revisit and update previously assigned keys.

Consequently, even after moving the camera and Replicator providing correct labels for these previously "unlabelled" objects, our key array fails to update this information and continues to mark them as "unlabelled".

Proposed Solution

  1. Internally track keys marked as "unlabelled".
  2. For each new segmentation map:
    a. Check if any tracked "unlabelled" keys have been assigned valid labels.
    b. If so, retrospectively update our key array to reflect the new, valid label.

@hang-yin hang-yin self-assigned this Oct 10, 2024
@hang-yin hang-yin requested a review from cremebrule October 17, 2024 00:02
@hang-yin hang-yin added this to the v1.2.0 milestone Oct 17, 2024
@cgokmen cgokmen merged commit 942ca2b into og-develop Oct 24, 2024
21 checks passed
@cgokmen cgokmen deleted the fix/key-array-caching branch October 24, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants