fix(bzlmod): correctly wire the extra_pip_args #2258
+58
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
However this is not a test for the code in question as those tests probably need to wait for bazelbuild#2253 to land to make the test writing easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we were just dropping the
extra_pip_argspassed topip.parseand were just using the args passed through the requirementsfile. Thanks to @swarren12 for pointing this out.
This PR also passes
extra_pip_argstosdistwhl_libraryinstancesso that users can build the
sdistscorrectly when usingexperimental_index_urlfeature.Summary:
extra_pip_argswhen building sdists in experimental modeextra_pip_argsfrom the file and the pip.parse attrFixes #2239
Closes #2254