Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone Do not Disturb #4427

Merged
merged 4 commits into from
Oct 7, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Sep 17, 2023

About the pull request

Allows phones to be put on Do Not Disturb, preventing them from being called. This is not possible to toggle on certain phones such as Overwatch.

Explain why it's good for the game

Sometimes phones get spammed for trolls, other times the relevant people (like CL) are not in their office. This makes it easy to stop wasted calls on empty rooms or busy people.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added a Do Not Disturb feature for MOST phones. (Overwatch and a couple others excluded).
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? UI deletes nanoui/html Feature Feature coder badge labels Sep 17, 2023
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code good

@morrowwolf morrowwolf marked this pull request as draft September 23, 2023 07:44
@ghost
Copy link

ghost commented Sep 23, 2023

Currently, when the button is pressed it doesn't change its color or update the button text or have any visible state change in tgui, It feels like it should though...

@realforest2001 realforest2001 marked this pull request as ready for review September 30, 2023 19:33
@realforest2001
Copy link
Member Author

Currently, when the button is pressed it doesn't change its color or update the button text or have any visible state change in tgui, It feels like it should though...

The hover-text and the icon on the button do update when the state is changed

@ghost
Copy link

ghost commented Sep 30, 2023

I didn't notice it in-game when I first commented and didn't look at the code, I see it in the code now.

Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dunno why this has sat so long

@Zonespace27 Zonespace27 added this pull request to the merge queue Oct 7, 2023
Merged via the queue into cmss13-devs:master with commit e39f360 Oct 7, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Oct 7, 2023
@realforest2001 realforest2001 deleted the forest/phonesnooze branch October 21, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Mapping did you remember to save in tgm format? UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants