-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helmet Optics Update #4549
Helmet Optics Update #4549
Conversation
No real sprite changes, just renaming. |
Also I hate how the recharger works and I'm gonna refactor it into something else at some point just don't yell at me for how cursed it is right now bless |
Alright so now we do actually have sprites |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool sprites
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code seems good
# About the pull request removes an outdated xeno tip about breaking NVG goggles (you couldn't as of #4549) removes a doublespace on a tip adds a new tip about targeting marines based on what they're (not) wearing <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game tips not being outdated... good??? new tips good I think. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: add: Added a new xeno tip about where to target. spellcheck: changed a few tips' wording. del: Removed an outdated xeno tip about slashing NVGs /:cl:
About the pull request
This PR:
Adds NVG optics
Removes functional tube NVGs from gameplay
Adds a hotkey to cycle optics
Refactors a bunch of backend optic stuff to make it less redundant
Stops helmet destruction, or somehow visors in helmets destruction ???, from forcing a HUD or effect to stay on
Adds special marine raider optic which gives night vision, medical readouts, and USCM HUD.
Adds examine text for visors
Adds research publication to advanced medical optic
Explain why it's good for the game
Optics are awesome!
Better code is good (at least I hope it's better)
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 Morrow
add: Added NVG optics
add: Added a hotkey to cycle optics
add: Added special marine raider optic
add: Added examine text for optics
add: Added research publication to advanced medical optic
del: Removed functional tube NVGs from gameplay
refactor: Moved some optics code around to make it less redundant
fix: Fixed a bug with duplicate optic actions
fix: Fixed a reported bug where HUDs would stay on forever with destruction of a helmet
/:cl: