Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M39 being able to use vertical grip again [BUFF] #4627

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

irakligabunia
Copy link
Contributor

@irakligabunia irakligabunia commented Oct 10, 2023

About the pull request

M39 receives a buff, which allows it to use a attachment that make sit viable.

Explain why it's good for the game

M39 as it stands is quite useless, the vertical grip might help it become a viable choice over the M4RA, the MK2 and the M37 :)

Testing Photographs and Procedure

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 stalkerino
balance: m39 is able to use vertigrip
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Oct 10, 2023
@@ -51,6 +51,7 @@
/obj/item/attachable/reddot,
/obj/item/attachable/reflex,
/obj/item/attachable/angledgrip,
/obj/item/attachable/verticalgrip,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont use space for indentation. tab instead

@fira fira marked this pull request as draft October 10, 2023 23:10
@Zonespace27
Copy link
Contributor

I'm willing to try it. No guarantees on a merge.

@Zonespace27 Zonespace27 added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Oct 11, 2023
@irakligabunia irakligabunia marked this pull request as ready for review October 11, 2023 17:08
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 19, 2023
@Zonespace27 Zonespace27 removed the Stale beg a maintainer to review your PR label Oct 19, 2023
@Zonespace27 Zonespace27 added Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. and removed Testmerge Candidate we'll test this while you're asleep and the server has 10 players labels Oct 22, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'm happy with what I've seen.

@Zonespace27 Zonespace27 added this pull request to the merge queue Oct 22, 2023
Merged via the queue into cmss13-devs:master with commit 5a48d2c Oct 22, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants