Fixes Smartfridge deletions + Turing/Smartfridge networking issue #4696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This fixes 2 things:
item_quants
keeping references preventing contents deletionitem_quants
when trying to delete empty bottlesThe second would manifest as such in game logs:
RUNTIME: type mismatch: -4 += Phoron bottle (/obj/item/reagent_container/glass/bottle) - code/game/machinery/kitchen/smartfridge.dm@136
because the Turing was still using it as a number and not a list.
This probably fixes all sorts of weirdnesses with Turing/Fridge and possibly links to #4694 - but i recommend this be TMed by Real Research Mains to ensure nothing broke
Explain why it's good for the game
Less bugs more consistency
Testing Photographs and Procedure
Tested simple Turing usage, and chemical auto-bottling (looping phoron without new chems creation)
Changelog
🆑
fix: Fixed various issues in the Networking between Turing machine and Smartfridges.
/:cl: