Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Smartfridge deletions + Turing/Smartfridge networking issue #4696

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

fira
Copy link
Member

@fira fira commented Oct 16, 2023

About the pull request

This fixes 2 things:

  • Smartfridges deletion would not clean item_quants keeping references preventing contents deletion
  • The Turing machine was never updated to work with new Smartfridges and would botch item_quants when trying to delete empty bottles

The second would manifest as such in game logs:
RUNTIME: type mismatch: -4 += Phoron bottle (/obj/item/reagent_container/glass/bottle) - code/game/machinery/kitchen/smartfridge.dm@136
because the Turing was still using it as a number and not a list.

This probably fixes all sorts of weirdnesses with Turing/Fridge and possibly links to #4694 - but i recommend this be TMed by Real Research Mains to ensure nothing broke

Explain why it's good for the game

Less bugs more consistency

Testing Photographs and Procedure

Tested simple Turing usage, and chemical auto-bottling (looping phoron without new chems creation)

Changelog

🆑
fix: Fixed various issues in the Networking between Turing machine and Smartfridges.
/:cl:

@fira fira added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Oct 16, 2023
@github-actions github-actions bot added the Fix Fix one bug, make ten more label Oct 16, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Oct 24, 2023
Copy link
Member

@realforest2001 realforest2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harryob harryob added this pull request to the merge queue Oct 26, 2023
Merged via the queue into cmss13-devs:master with commit 2507b46 Oct 26, 2023
27 checks passed
cm13-github added a commit that referenced this pull request Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants