Alternative IFF

[ihatethisengine]

About the pull request

IFF no longer allows you to shoot past allies, instead it just prevents you from shooting if there is a friendly on your line of fire. Bullets still cannot hurt friendlies if something goes wrong.

Rebalanced some of the weapons to make them work with the change:
Smartgun: increased damage from 30 to 36, increased armor piercing bullet damage from 20 to 24.
Smartpistol: increased damage from 30 to 36.
M56D: increased damage from 35 to 36, reduced firedelay from 0.3 to 0.25 for full-auto.
Smart-scope: removed damage reduction, added additional 8 ticks firedelay when IFF procs, so accuracy still matters. Also halved the time it takes to activate the scope.
M46C: no longer becomes weaker when IFF is enabled, also can use full-auto and burst-fire with IFF.

The rest of the guns (including M42A, GL, flaregun) still use the old system.

Most of the work done by MorrowWolf, I ported it from his project: https://github.com/PvE-CMSS13/PvE-CMSS13.

Explain why it's good for the game

IFF always has been an issue. Potentially it's very strong, because it can be stacked. But because of its potential, guns with IFF on their own are made very weak, which is only further encourage players to murderball and stack IFF. It's a nightmare for balance and for gameplay, so this is why I am trying to change it. Also it makes a bit more sense than magic bullets and this is more lore-accurate AFAIK.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

iff.mp4

Changelog

🆑 MorrowWolf, ihatethisengine
add: Added new IFF system, that prevents user from firing weapon if there are friendlies on the line of fire.
balance: Smartgun, smartpistol, M56D, M46C and smart-scope all use new IFF system now.
balance: Increased smartgun damage from 30 to 36, increased armor piercing bullet damage from 20 to 24.
balance: Increased smartpistol damage from 30 to 36.
balance: Slightly increased damage and firerate of M56D.
balance: Smart-scope no longer reduces damage, guns with smart-scope get firedelay when user tries to shoot a friendly. Also halved the time it takes to activate the scope.
balance: M46C doesn't become weaker when IFF is enabled.
/:cl:

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[cm13-github]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[cm13-github]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself