M4 Synthetic PMC 'armor' changes #4758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
This comment was marked as off-topic.
This comment was marked as off-topic.
Zonespace27
approved these changes
Oct 25, 2023
Zonespace27
added
the
Balance Approved
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
closing and atomizing |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
# About the pull request <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> this is #4758 but atomized, this one only changes code, next one will only change sprite. the conflicts involved with sprites was quite ridiculous Basically M4 PMC Synthetic 'armor' stated it offered 'maximum protection' even though it offers quite literally 0. Furthermore this complete lack of protection does not constitute the 20% slowdown netted. So I'm fixing the description to state clearly that there is NO ARMOR OFFERED and furthermore, lowering it to a 10% slowdown(Justified by having 1 extra storage space?). I think this is a step in teh right direction for now. 10% comes from a new category called SUPERLIGHT which will be used for this only atm. May go to other stuff later. # Explain why it's good for the game Description should match what an item offers and not be misleading. If it says it has armor - it should have armor. If it isn't gonna have armor, it shouldn't say so. Next, 20% slowdown is A HUGE price for 1 single storage slot. Its almost ridiculous. Hopefully 10% is better :) # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: add: SUPERLIGHT armor category. balance: M4 Synthetic Armor slows by 10% to justify having 1 extra storage slot. spellcheck: Clarifies M4 Synthetic Armor description that it does not have any armor whatsoever. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Basically M4 PMC Synthetic 'armor' stated it offered 'maximum protection' even though it offers quite literally 0. Furthermore this complete lack of protection does not constitute the 20% slowdown netted.
So I'm fixing the description to state clearly that there is NO ARMOR OFFERED and furthermore, lowering it to a 10% slowdown(Justified by having 1 extra storage space?). I think this is a step in teh right direction for now.
10% comes from a new category called SUPERLIGHT which will be used for this only atm. May go to other stuff later.
Explain why it's good for the game
Description should match what an item offers and not be misleading. If it says it has armor - it should have armor. If it isn't gonna have armor, it shouldn't say so.
Next, 20% slowdown is A HUGE price for 1 single storage slot. Its almost ridiculous. Hopefully 10% is better :)
Next, people said the armor looks fat on the side so I slimmed it by 4 pixels.(1 column)
Testing Photographs and Procedure
[Screenshots & Videos](https://cdn.discordapp.com/attachments/777257424590995466/1165287130080215060/image.png?ex=65464d35&is=6533d835&hm=7124d336618ce31ead8398615fcf3903c4ecc1cc8d646aa2604d877e89ff2276&)
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
add: SUPERLIGHT armor category.
balance: M4 Synthetic Armor slows by 10% to justify having 1 extra storage slot.
spellcheck: Clarifies M4 Synthetic Armor description that it does not have any armor whatsoever.
/:cl: