Weeds are conserved under walls being upgraded and destroyed #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
approved these changes
Dec 1, 2023
fira
added
Testmerge Candidate
|
For the record, this is a behavior that seems to go all the way back to Wallrot introduction in Baystation12 about ten years ago. I don't think there's strong arguments to keeping it |
realforest2001
approved these changes
Dec 1, 2023
Drulikar
approved these changes
Dec 2, 2023
cm13-github
added a commit
that referenced
this pull request
Dec 3, 2023
3 tasks
3 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
# About the pull request #5096 left "weed walls" behind when non resin walls are destroyed. This reintroduces the check but narrows it to only `/obj/effect/alien/weeds/weedwall` so normal "floor weeds" are still unaffected. But "wall weeds" will die... Fixes #5135 # Explain why it's good for the game # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: Wall weeds now destroyed when closed wall turfs are changed. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Fixes #5060
Side effect of this PR is that when resin walls are destroyed then do not remove the weeds underneath. However those weeds should still be linked to a nearby node and recede as normal when that is destroyed.
Explain why it's good for the game
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Upgraded resin walls can now nest hosts.
/🆑