Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xenos now see marines on the tacmap during hijack if xenos outnumber marines for more than 25% #5278

Merged
merged 7 commits into from
Jan 6, 2024

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Dec 22, 2023

About the pull request

Xenos now see marines on the tacmap during hijack if xenos outnumber marines for more than 25%.

Explain why it's good for the game

Hide and seek is boring. Queen need to be on ovi to access tacmap, so marines would still have a chance.

Testing Photographs and Procedure

Screenshots & Videos I am lazy but it worked when I tested.

Changelog

🆑 ihatethisengine
add: Xenos now see marines on the tacmap during hijack if xenos outnumber marines for more than 25%.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Dec 22, 2023
@fira fira added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Dec 26, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but what about corrupted / Xeno ERT etc ? Should they be revealed on low human count too ?

@ihatethisengine
Copy link
Contributor Author

I think this code let you see basically everyone, just like observers can see all factions on the tacmap. Anyway, iirc greenos and feral don't count towards round end, so it shouldn't be really relevant.

@Skatuk
Copy link

Skatuk commented Dec 28, 2023

Does the last guy dissapear from the tacmap? You already have the QM giving you directions. And its the last guy against 20 xeno's

@ihatethisengine
Copy link
Contributor Author

Not really a situation I care about in particular. If there is one guy against twenty xenos, I'd rather have them to die quickly than to run around for 10-15 minutes. QM message happens only once per two minutes and by the time you get there they might already be gone. Not a situation I want to make exceptions for.

code/controllers/subsystem/minimap.dm Outdated Show resolved Hide resolved
code/controllers/subsystem/minimap.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft December 31, 2023 10:25
@ihatethisengine ihatethisengine marked this pull request as ready for review December 31, 2023 10:42
@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Dec 31, 2023
code/controllers/subsystem/minimap.dm Outdated Show resolved Hide resolved
@SabreML
Copy link
Member

SabreML commented Jan 2, 2024

It may have been mentioned already, but for some reason the aft section of the ship is cut off on the map:

Hidden since it's a big image:

image

So if someone's hiding at lifeboats for example, they probably won't be visible.

@Drulikar
Copy link
Contributor

Drulikar commented Jan 2, 2024

It may have been mentioned already, but for some reason the aft section of the ship is cut off on the map:

So if someone's hiding at lifeboats for example, they probably won't be visible.

Out of scope for this PR to resolve unless ihate really wants to - but also pretty minor. Also the drawn on map (should the queen do so) is more zoomed out too.

@Drulikar
Copy link
Contributor

Drulikar commented Jan 2, 2024

If you do want to tackle it though, its as simple as increasing the size of icons/ui_icons/minimap.dmi and then changing these values:
image
For example 512x512 would look like this:
image
image

You'd have to increase it a fair bit more to get the AI core.

But you will want to see how this looks on all maps in all interfaces (squad computers, CAS UI, etc).

@ihatethisengine
Copy link
Contributor Author

Let's get this merged first, then when I have time I will look into it and make a separate PR.

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jan 3, 2024
@Drulikar Drulikar marked this pull request as draft January 3, 2024 23:11
@ihatethisengine ihatethisengine marked this pull request as ready for review January 6, 2024 14:59
@harryob harryob added this pull request to the merge queue Jan 6, 2024
Merged via the queue into cmss13-devs:master with commit d826531 Jan 6, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants