Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to bone repairing #5280

Merged
merged 19 commits into from
Jan 23, 2024
Merged

Changes to bone repairing #5280

merged 19 commits into from
Jan 23, 2024

Conversation

BeagleGaming1
Copy link
Contributor

About the pull request

Bone glue is limited, with 5% glue used per repair
Repairing bones with a screwdriver costs 2 metal sheets per repair
Adds a machine to the USS Almayer that allows you to refill bone glue

Explain why it's good for the game

By limiting bone glue, you will limit the amount of surgery that happens groundside without sacrificing other resources that have important use, or by having additional supplies delivered.
If there is a limit to how much surgery can be done, it will force the groundside surgeon to prioritize and consider the severity of the injuries, instead of fully repairing every bone.
This will increase the consequences from getting injured and having broken bones, by requiring you to either work with the downside via splints, or to return shipside.
There should be no changes to shipside surgery, as the machine should be close enough to replenish without having any problems.

Changelog

🆑
balance: Repairing bones with bone glue costs a portion of the bone glue's resources
balance: Repairing bones with a screwdriver costs metal
del: Removed bone glue from the medilathe
spellcheck: New description for bone glue
/:cl:

@BeagleGaming1 BeagleGaming1 changed the title Changes to bone repair Changes to bone repairing Dec 23, 2023
@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Removal snap Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Dec 23, 2023
@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review December 23, 2023 00:47
@Steelpoint
Copy link
Contributor

Does this affect Predator bonegel surgical tools? If so, you may want to add a refiller to their ship. Very edge case scenario admittedly.

@BeagleGaming1
Copy link
Contributor Author

Does this affect Predator bonegel surgical tools? If so, you may want to add a refiller to their ship. Very edge case scenario admittedly.

image

@kooarbiter
Copy link

5 percent seems like a lot for a tool you have to raid surgery to get any more of, I dont think you can get bonegel by itself via cargo or research.

@ghost

This comment was marked as abuse.

Sign in to view
@ghost

This comment was marked as off-topic.

Sign in to view
@ghost

This comment was marked as abuse.

Sign in to view
Nanu308
Nanu308 approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Dec 24, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Dec 25, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@BeagleGaming1 BeagleGaming1 marked this pull request as draft December 25, 2023 18:38
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Dec 25, 2023
@BeagleGaming1 BeagleGaming1 marked this pull request as ready for review December 25, 2023 19:01
@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 16, 2024
@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR Needs Testing Need to test it on the guinea pigs (production server) labels Jan 16, 2024
@Birdtalon Birdtalon mentioned this pull request Jan 16, 2024
Closed
3 tasks
@Bagpepos Bagpepos mentioned this pull request Jan 17, 2024
Closed
3 tasks
@ValiantEar ValiantEar mentioned this pull request Jan 17, 2024
Open
3 tasks
@Katskan Katskan mentioned this pull request Jan 17, 2024
Open
3 tasks
@Megaddd Megaddd mentioned this pull request Jan 17, 2024
Closed
3 tasks
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 18, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 19, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

nauticall
nauticall approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sproites

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Jan 23, 2024
@Drulikar Drulikar added this pull request to the merge queue Jan 23, 2024
@Drulikar Drulikar mentioned this pull request Jan 23, 2024
Merged
Merged via the queue into cmss13-devs:master with commit c7b4d6b Jan 23, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 23, 2024
@cm13-github
Automatic changelog for PR #5280 [ci skip]
085ca70
AlakRacc added a commit to AlakRacc/cmss13 that referenced this pull request Feb 3, 2024
@AlakRacc
Revert "Changes to bone repairing (cmss13-devs#5280)"
4af1abf 
This reverts commit c7b4d6b.

A big thanks to Birdtalon for helping me learn how to do this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drulikar Drulikar Drulikar approved these changes

@Nanu308 Nanu308 Nanu308 approved these changes

@nauticall nauticall nauticall approved these changes

@fira fira fira approved these changes

Assignees
No one assigned
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Removal snap Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Stale Exempt PR can't go stale Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.