Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requisition Centralization [Part 1] #5490

Merged
merged 3 commits into from
Jan 26, 2024

Conversation

ItsVyzo
Copy link
Contributor

@ItsVyzo ItsVyzo commented Jan 18, 2024

About the pull request

Adds a bolted version of the blood and medical vendors
Only the Field Equipment Vendors can down be taken down for FOB
Adds new pill bottle crate to requisitions
Makes medical crates ordered via req cheaper to compensate

Explain why it's good for the game

Centralizes requisition gameplay and increases its overall importance in the gameloop. This is just part 1 of a requisitions centralization update. I highly advise TMing this, to properly balance overall requestion prices and perhaps add more medical crates as needed

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 LTNTS
add: bolted version of blood and medical vendors
add: pill bottle crate
balance: cheaper medical crates from req
balance: less items in med vendors, mainly pill bottles
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels Jan 18, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapping lgtm

@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Jan 22, 2024
@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jan 23, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also incorporate your changes with the changes from #5280 (will likely conflict with this PR)

@Drulikar Drulikar dismissed their stale review January 23, 2024 12:56

Appears to have kept wrenchable states just fine despite medbay changing.

@ItsVyzo
Copy link
Contributor Author

ItsVyzo commented Jan 23, 2024

Please also incorporate your changes with the changes from #5280 (will likely conflict with this PR)

Mapping did not conflict somehow and #5280 changes are still there which is awesome

@Staykeu Staykeu mentioned this pull request Jan 24, 2024
3 tasks
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jan 25, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are fine and not seen any feedback regarding this during TMs.

@Drulikar Drulikar added this pull request to the merge queue Jan 25, 2024
Merged via the queue into cmss13-devs:master with commit b173347 Jan 26, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 26, 2024
@ItsVyzo ItsVyzo deleted the reqcentralization branch January 31, 2024 14:48
github-merge-queue bot pushed a commit that referenced this pull request Feb 1, 2024
# About the pull request

This PR is a follow up to #5490 that had an undocumented change of
resetting the medbay vendors to no access required.

# Explain why it's good for the game

Medbay vendors are for medbay. You should have medbay access to use
them. The change was unintentional.

However, compared to how it originally was, corpsmen now have access to
the vendors.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/76988376/b71aec79-3943-452c-98e0-c3e2e7605ffd)

![image](https://github.com/cmss13-devs/cmss13/assets/76988376/e3c094ab-c2f2-42de-a4eb-ef6c64f3df1b)


</details>


# Changelog
:cl: Drathek
balance: Compared to originally, corpsmen now have access to medbay
vendors, and chemistry only requires chemistry access.
fix: Fixed unintended change to medbay vendors access: 
/:cl:
github-merge-queue bot pushed a commit that referenced this pull request Apr 7, 2024
…outside medbay cheese removal redux (#5677)

# About the pull request

This PR adds a new structure: the medical supply link port. This is a
structure that allows medical vendors to link to the Almayer's internal
medical supplies and have larger restocking capabilities. They can be
found around the Almayer where existing medical vendors are.

This PR makes it impossible to restock/refill non full stacks at medical
vendors which are not linked to a medical supply link port

This PR makes it impossible to restock/refill non full autoinjectors and
bottles at medical vendors which are not linked to a medical supply link
port

revives #2155

# Explain why it's good for the game

This PR is good for the game because it will get req more involved in
the medical supply process, as well as limiting the capability of medics
to instantly resupply from a vendor at the fob or in hydro. This makes
it so that medics have to more carefully pick their supplies, and plan
ahead for resupplying, as well as consider other medics' use of
supplies, as nothing is infinite groundside anymore.

Overall, it will make the medic supply gameplay loop more engaging and
interesting, as well as reducing marine capability to infinitely heal
and resupply themselves groundside.

Makes #5490 more useable

# Testing Photographs and Procedure

<details>

https://gyazo.com/d9e8e3b63daab1241e046c23bb5dd140

</details>


# Changelog

🆑 Stan_albatross,kugamo,LTNTS,Drathek
balance: medical vendors, excepting nanomeds, can now only
refill/restock stacks and autoinjectors/bottles when on special medical
supply link ports that can only be found shipside. Sprite by kugamo.
fix: supply pads will no longer generate ambient occlusion.
/:cl:

---------

Co-authored-by: Nanu308 <[email protected]>
Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants