Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X17 Riot Breaching Charge #5285

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Dec 23, 2023

About the pull request

Adds the X17 breaching charge, similar to the normal marine breaching charge except it fires rubber pellets rather than metal shrapnel, for use by MPs.

Explain why it's good for the game

Allows MPs to have tools that break into secure places without immediately killing the occupants.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Added the X17 Riot Breaching Charge.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Dec 23, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local CM Dev uses explosion power = falloff and still sets EXPLOSION_FALLOFF_SHAPE_EXPONENTIAL 🥴

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with the slight color change this still resembles the regular breaching charge too much. I would recommend changing the color of the charge's body to red with a white stripe, or something similar, to distinguish it more.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jan 11, 2024
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good now 🦖

@nauticall nauticall added Sprites Approved confirmed no stray pixels and removed Stale beg a maintainer to review your PR labels Jan 11, 2024
@nauticall nauticall added this pull request to the merge queue Jan 11, 2024
Merged via the queue into cmss13-devs:master with commit 36bac31 Jan 11, 2024
26 checks passed
cm13-github added a commit that referenced this pull request Jan 11, 2024
@realforest2001 realforest2001 deleted the forest/riotcharge branch January 19, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants