Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Double Throw Delay #5526

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jan 23, 2024

About the pull request

This PR is simply a number tweak increasing the cooldown to throw two items.

Explain why it's good for the game

Throwing knives are still very powerful. This change brings them closer to an acceptable range, but even still they are rather deadly. Any amount past this though will likely make throwing other items too cumbersome. See Testing.

To elaborate further:

  • A 0.4s delay to throw two knives (assuming the player wants to get optimal damage out of them) is asking the player to retrieve a weapon, prepare to throw it, and throw it on a target every 0.2 seconds (This PR raises that period to 0.75s). This is just not practical to expect w/o the use of macros - and we don't want to encourage macro usage both because third party macros are not allowed (Rule 5) and byond macros will likely be disabled.
  • Throwing knives were already a problem before thus Throw Delay #3284 which added the 0.4s delay in the first place. But didn't do enough. In fact this PR probably doesn't do enough - but this is probably as far as the throwing delay should go. Anything else would either be how much damage they do or reduced likelihood of retrieval.
  • Throwing knives should not be comparable to primary weapons. They should be on the level of sidearms used as a backup weapon or weapons to use in conjunction with your primary weapon.

Testing Photographs and Procedure

Screenshots & Videos
Throwing.mp4

Changelog

🆑 Drathek
balance: Increased double throw delay from .4s to 1.5s
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jan 23, 2024
@ICA-usernameisunavailable

This comment was marked as off-topic.

Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

funny code good & grammar

@Wintermote
Copy link

I think this PR should focus exclusively on knives rather than affecting every single thrown object in the game.

@harryob harryob added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jan 30, 2024
@harryob harryob added this pull request to the merge queue Jan 30, 2024
Merged via the queue into cmss13-devs:master with commit 61f7b74 Jan 30, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jan 30, 2024
@Drulikar Drulikar deleted the Increase_Throw_Delay branch January 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants