refactor barricades files to hopfully have a more constant interaction when trying to fix them with welder. #5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
January 30, 2024 16:53
…ade with an welder.
github-actions
bot
added
Refactor
3 tasks
Birdtalon
reviewed
Feb 5, 2024
added 10 commits
February 6, 2024 10:57
Birdtalon
suggested changes
Feb 7, 2024
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
Birdtalon
suggested changes
Feb 20, 2024
Birdtalon
suggested changes
Feb 20, 2024
Co-authored-by: Birdtalon <[email protected]>
Birdtalon
approved these changes
Feb 21, 2024
cm13-github
added a commit
that referenced
this pull request
Feb 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 24, 2024
# About the pull request This PR is a follow up to #5609 which removed a busy check from some barricades allowing multi-welding. This PR restores that setting (which is a return to normal for all but folding barricades which incorrectly allowed multi-welding before). I have also added automatic looping to barricade welding if there is still work to be done, and it can be performed. # Explain why it's good for the game The PR that introduced this change was not intended to be a balance change. Additionally, it's far more difficult to tune welding speeds if the quantity of barricades being welded at the same time is variable. Technically this is a nerf though because previously multi-welding folding barricades was possible. # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> https://github.com/cmss13-devs/cmss13/assets/76988376/32deb97f-31b0-4fd0-8baf-54637cfbf81d After looping welding addition: https://github.com/cmss13-devs/cmss13/assets/76988376/e67efe06-711e-4847-aa36-345c1e85222d </details> # Changelog :cl: Drathek add: Welding a barricade will now repeat automatically if it can still be repaired. balance: Reverted multi-welding change to barricades: All barricades must be welded one at a time. refactor: Refactored more barricade code. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
fixes: #5229
1-replace a bunch of single letter variable and in the same movement standardize it for all the parent/child object...
2-create a proc that is a group of check to see if you can start fixing a barricade with a welder.
3-implement this proc on metal,plasteel and deployable to have all the check be the same as we want them to all react the same way...
Explain why it's good for the game
Testing Photographs and Procedure
i tested welding different different cades at the same time seem to work i had some weirdness but it's working.
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: refactored files with the aim of making fixing barricade with a welder more constant.
fix: being unable to repair more than one metal barricade at the time.
/:cl: