Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biosuit Updates #5925

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Mar 11, 2024

About the pull request

Updates the various department subtype biosuits to use the modern sprites.
Removes the janitor biosuit because we don't need it.
Partially updates how diseases work in regards to armor_bio.

Tested and confirmed working as intended.

Explain why it's good for the game

Makes all the biosuits look the same, rather than having one type look modern and the others use legacy sprites which are quite glaring compared to the new version. Also is more realistic to have biosuits actually impact how diseases spread.

Testing Photographs and Procedure

Screenshots & Videos

image

Changelog

🆑
imageadd: Updated all the biosuit sprites to use the modern version rather than legacy.
imageadd: Updated the biosuit locker sprites to use a consistent base scheme.
del: Removed Janitor biosuits.
maptweak: Updated a couple places using the wrong biosuit lockers, and replaced janitor ones.
code: Changed some parts of disease code so it respects armor_bio more.
add: Makes CBRN and Biosuit hoods protect from gas, as would be expected.
balance: Biosuit hood armor_bio increased to match the biosuit itself.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Mapping did you remember to save in tgm format? Removal snap Code Improvement Make the code longer labels Mar 11, 2024
Copy link
Contributor

@sleepynecrons sleepynecrons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites approved

@sleepynecrons sleepynecrons added the Sprites Approved confirmed no stray pixels label Mar 11, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mapping lgtm on le maps

maps/map_files/BigRed/BigRed.dmm Outdated Show resolved Hide resolved
@Nanu308 Nanu308 added the Mapping Approved adds 500 new dict keys label Mar 13, 2024
cm13-github added a commit that referenced this pull request Mar 15, 2024
cm13-github added a commit that referenced this pull request Mar 15, 2024
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Mar 15, 2024
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Mar 15, 2024
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

cm13-github added a commit that referenced this pull request Mar 15, 2024
@realforest2001 realforest2001 removed the Sprites Approved confirmed no stray pixels label Mar 15, 2024
cm13-github added a commit that referenced this pull request Mar 15, 2024
cm13-github added a commit that referenced this pull request Mar 16, 2024
@realforest2001 realforest2001 marked this pull request as ready for review September 7, 2024 21:22
cm13-github added a commit that referenced this pull request Sep 7, 2024
cm13-github added a commit that referenced this pull request Sep 8, 2024
cm13-github added a commit that referenced this pull request Sep 9, 2024
cm13-github added a commit that referenced this pull request Sep 9, 2024
cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Sep 10, 2024
cm13-github added a commit that referenced this pull request Oct 12, 2024
cm13-github added a commit that referenced this pull request Oct 13, 2024
cm13-github added a commit that referenced this pull request Oct 13, 2024
cm13-github added a commit that referenced this pull request Oct 13, 2024
@Nanu308 Nanu308 added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Oct 13, 2024
Copy link
Member

@Nanu308 Nanu308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i throw in a balance approval before this dies entirely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Mapping Approved adds 500 new dict keys Mapping did you remember to save in tgm format? Removal snap Sprites Approved confirmed no stray pixels Sprites Frozen Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants