-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lurker invis toggling #6148
Merged
Merged
Lurker invis toggling #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework lurker invis to allow toggling and partial refund based on time used for devour/bump Devour now decloaks
github-actions
bot
added
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Removal
snap
labels
Apr 15, 2024
Drulikar
added
the
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
label
Apr 15, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Drulikar
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Apr 16, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 20, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 20, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 20, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 21, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 21, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 22, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 23, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
cm13-github
added a commit
that referenced
this pull request
Apr 23, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 24, 2024
3 tasks
cm13-github
added a commit
that referenced
this pull request
Apr 24, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 24, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 25, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 25, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 25, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 26, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 26, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 26, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 26, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 27, 2024
realforest2001
approved these changes
Apr 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
cm13-github
added a commit
that referenced
this pull request
Apr 27, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 28, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 29, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 29, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 29, 2024
3 tasks
cm13-github
added a commit
that referenced
this pull request
Apr 30, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 30, 2024
cm13-github
added a commit
that referenced
this pull request
Apr 30, 2024
3 tasks
Add double click prevention (0.5s just like I did for /datum/action/xeno_action/activable previously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Balance Approved
This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it.
Balance
You need to be a professional veteran game maintainer to comprehend what is being done here.
Feature
Feature coder badge
Fix
Fix one bug, make ten more
Removal
snap
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is sort of a different implementation of #6127 opting against balloon alerts for devour that does several things:
Explain why it's good for the game
Gives lurkers more flexibility to have their ability ready when they may need it, resolves the issue of lurkers trying to sneak a devour, and makes bumping slightly less punishing.
The increase in the recharge time is intended to make an ambush more calculated offering marines a little more time to retaliate before the lurker may vanish again.
Testing Photographs and Procedure
Screenshots & Videos
https://youtu.be/ODEF7E6lDrI
Changelog
🆑 Drathek
balance: Lurker invisibility recharge time is now 20s (up from 15s)
balance: Lurker invisibility now ends when devouring but refunds 50% of time unused
balance: Lurker invisibility bump now refunds 50% of time unused
balance: Lurker invisibility can now be toggled refunding 90% of time unused (with dbl click prevention)
del: Removed defender crest toggle balloon alerts
fix: Lurker invisibility code is refactored to properly use cooldowns and now doesn't incorrectly get interrupted by bump code
add: Lurker invisibility recharge time is now displayed in status tab
/:cl: