Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lurker invis toggling #6148

Merged
merged 4 commits into from
May 1, 2024
Merged

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Apr 15, 2024

About the pull request

This PR is sort of a different implementation of #6127 opting against balloon alerts for devour that does several things:

  • Lurker invis recharge is now 20s base (up from 15s)
  • Lurker invis can now be toggled giving you 90% of the time you didn't use (and with 0.5s of double click prevention like I previously gave to all /datum/action/xeno_action/activable )
  • Bumping still ends invisibility but refunds 50% of the time you didn't use
  • Devouring now ends invisibility but refunds 50% of the time you didn't use
  • Removed balloon alerts for defender crest toggling
  • Code refactor to actually utilize xeno ability cooldowns means that CDR can affect the ability now, but xenos have very little access to CDR
  • Changes the invisibility time remaining status message to also mention invisibility recharge time.

Explain why it's good for the game

Gives lurkers more flexibility to have their ability ready when they may need it, resolves the issue of lurkers trying to sneak a devour, and makes bumping slightly less punishing.

The increase in the recharge time is intended to make an ambush more calculated offering marines a little more time to retaliate before the lurker may vanish again.

Testing Photographs and Procedure

Screenshots & Videos

https://youtu.be/ODEF7E6lDrI

Changelog

🆑 Drathek
balance: Lurker invisibility recharge time is now 20s (up from 15s)
balance: Lurker invisibility now ends when devouring but refunds 50% of time unused
balance: Lurker invisibility bump now refunds 50% of time unused
balance: Lurker invisibility can now be toggled refunding 90% of time unused (with dbl click prevention)
del: Removed defender crest toggle balloon alerts
fix: Lurker invisibility code is refactored to properly use cooldowns and now doesn't incorrectly get interrupted by bump code
add: Lurker invisibility recharge time is now displayed in status tab
/:cl:

Rework lurker invis to allow toggling and partial refund based on time used for devour/bump
Devour now decloaks
@github-actions github-actions bot added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Removal snap labels Apr 15, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Apr 15, 2024
@Drulikar Drulikar marked this pull request as ready for review April 15, 2024 03:00
@CheeseToxin

This comment was marked as off-topic.

@Drulikar Drulikar added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Apr 16, 2024
cm13-github added a commit that referenced this pull request Apr 20, 2024
cm13-github added a commit that referenced this pull request Apr 20, 2024
cm13-github added a commit that referenced this pull request Apr 20, 2024
cm13-github added a commit that referenced this pull request Apr 21, 2024
cm13-github added a commit that referenced this pull request Apr 21, 2024
cm13-github added a commit that referenced this pull request Apr 22, 2024
cm13-github added a commit that referenced this pull request Apr 23, 2024
@Lukaster42

This comment was marked as off-topic.

cm13-github added a commit that referenced this pull request Apr 23, 2024
@Drulikar Drulikar added the Fix Fix one bug, make ten more label Apr 24, 2024
cm13-github added a commit that referenced this pull request Apr 24, 2024
cm13-github added a commit that referenced this pull request Apr 24, 2024
cm13-github added a commit that referenced this pull request Apr 24, 2024
cm13-github added a commit that referenced this pull request Apr 25, 2024
cm13-github added a commit that referenced this pull request Apr 25, 2024
cm13-github added a commit that referenced this pull request Apr 25, 2024
cm13-github added a commit that referenced this pull request Apr 26, 2024
cm13-github added a commit that referenced this pull request Apr 26, 2024
cm13-github added a commit that referenced this pull request Apr 26, 2024
cm13-github added a commit that referenced this pull request Apr 26, 2024
cm13-github added a commit that referenced this pull request Apr 27, 2024
Copy link
Member

@realforest2001 realforest2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

cm13-github added a commit that referenced this pull request Apr 27, 2024
@Shibouze Shibouze mentioned this pull request Apr 27, 2024
3 tasks
@Biolock1 Biolock1 mentioned this pull request Apr 28, 2024
3 tasks
cm13-github added a commit that referenced this pull request Apr 28, 2024
cm13-github added a commit that referenced this pull request Apr 29, 2024
cm13-github added a commit that referenced this pull request Apr 29, 2024
cm13-github added a commit that referenced this pull request Apr 29, 2024
cm13-github added a commit that referenced this pull request Apr 30, 2024
cm13-github added a commit that referenced this pull request Apr 30, 2024
cm13-github added a commit that referenced this pull request Apr 30, 2024
Add double click prevention (0.5s just like I did for /datum/action/xeno_action/activable previously
@github-actions github-actions bot added the Feature Feature coder badge label May 1, 2024
@realforest2001 realforest2001 added this pull request to the merge queue May 1, 2024
Merged via the queue into cmss13-devs:master with commit be29b4d May 1, 2024
27 checks passed
cm13-github added a commit that referenced this pull request May 1, 2024
@Drulikar Drulikar deleted the Lurker_Invis branch May 1, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Fix Fix one bug, make ten more Removal snap Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants