Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STEEL DIVISON (Re-introduces 200 pop locked tank) [CODE BOUNTY] #6304

Merged
merged 30 commits into from
Jun 19, 2024

Conversation

Red-byte3D
Copy link
Contributor

@Red-byte3D Red-byte3D commented May 17, 2024

About the pull request

Re-introduces the tank and tank crew back into the game, unlocking at 200 pop.

Explain why it's good for the game

to do list
re-introduce VC ✅
re-introduce Tank ✅
re-introduce tank attachements ✅
Make crewmen start with gear preset ✅
add pop lock ✅
fix bugs ✅
crew man / tank crew consistency ✅
crawl / ledge ✅

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: Re-adds Vehicle Crewmen
balance: Tank now unlocks at 200 pop.
balance: Re-adds tank and its attachements back to the tank-bay.
balance: You can no longer have the ARC & TANK in the same round. if the arc is bought the tank is unavailable and vice versa.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Balance You need to be a professional veteran game maintainer to comprehend what is being done here. labels May 17, 2024
@Red-byte3D Red-byte3D changed the title STEEL DIVISON (Re-intorduces 200 pop locked tank) [DRAFT] STEEL DIVISON (Re-introduces 200 pop locked tank) [DRAFT] May 17, 2024
@Huffie56
Copy link
Contributor

Huffie56 commented May 18, 2024

i put the only issue i found and remember about APC here. it's about sprite getting unsynced.
#5041

@Red-byte3D Red-byte3D marked this pull request as ready for review May 23, 2024 15:11
code/__DEFINES/job.dm Outdated Show resolved Hide resolved
code/__DEFINES/job.dm Outdated Show resolved Hide resolved
code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
code/__DEFINES/mode.dm Outdated Show resolved Hide resolved
code/modules/vehicles/tank/tank.dm Outdated Show resolved Hide resolved
code/game/jobs/slot_scaling.dm Outdated Show resolved Hide resolved
code/game/jobs/job/command/auxiliary/tank_crew.dm Outdated Show resolved Hide resolved
code/game/jobs/job/command/auxiliary/tank_crew.dm Outdated Show resolved Hide resolved
code/game/jobs/slot_scaling.dm Outdated Show resolved Hide resolved
@Nanu308 Nanu308 removed the Mapping did you remember to save in tgm format? label May 27, 2024
@Red-byte3D Red-byte3D marked this pull request as draft May 28, 2024 01:31
cm13-github added a commit that referenced this pull request Jun 16, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
cm13-github added a commit that referenced this pull request Jun 16, 2024
@Harrysno Harrysno mentioned this pull request Jun 17, 2024
3 tasks
cm13-github added a commit that referenced this pull request Jun 17, 2024
@Drulikar
Copy link
Contributor

Address feedback and undraft otherwise expect this closed for being stale by the end of this month.

@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jun 18, 2024
@Red-byte3D Red-byte3D marked this pull request as ready for review June 19, 2024 14:25
@Red-byte3D
Copy link
Contributor Author

everything should be addressed now, i will make a seperate pr to atomize the balance stuff and a few more fixes for the flamethrowe / minigun

cm13-github added a commit that referenced this pull request Jun 19, 2024
code/modules/cm_tech/techtree.dm Outdated Show resolved Hide resolved
@harryob harryob enabled auto-merge June 19, 2024 20:53
cm13-github added a commit that referenced this pull request Jun 19, 2024
@harryob harryob added this pull request to the merge queue Jun 19, 2024
Merged via the queue into cmss13-devs:master with commit b77b297 Jun 19, 2024
27 checks passed
cm13-github added a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale Exempt PR can't go stale Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants