Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAWLING !!!! #6561

Closed
wants to merge 13 commits into from
Closed

CRAWLING !!!! #6561

wants to merge 13 commits into from

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Jun 25, 2024

About the pull request

Xenomorphs of tier 1 can now use stalk mode to run on all 4 legs , this provides them with the ability to go thru other xenos and dodge stray bullets at the cost of some speed and being unable to use abilities.

IMPORTANT :

  • FOR NOW IT WILL BE MADE ONLY FOR T1S UNTIL TESTED. ( it can be done on T2s but only for visual effect for now)
  • WALL LATCHING WILL BE DONE IN A SEPARATE PR AFTER THIS ONE
    -STALKING MODE ONLY GIVES MECHANICAL BENEFITS FOR THE FOLLOWING CASTES :
    -Drone (no slowdown)
    -Sentinel (slows you down)
    -Runner (slows you down)
    -Lesser Drone (no slowdown)

credit to : Zenith,Blundir for sprites

Explain why it's good for the game

it looks cool and gives stalk mode usefullness.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Zenith, Blundir, Diegoflores31
add: Adds Utility to Stalk mode for T1 xenomorphs
balance: Crawling on small xenos allows you to pass thru other xenos and evasion at the cost of your abilities
code: Adds support for custom Walking/Running speeds for xenomorphs and Human subtypes
imageadd: added "walking" icons for some xeno castes.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer labels Jun 25, 2024
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add screenshots/videos

@Diegoflores31
Copy link
Contributor Author

image

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 8, 2024
@Drulikar
Copy link
Contributor

Stale exempt until sprite reviewed

@Drulikar Drulikar added Stale Exempt PR can't go stale and removed Stale beg a maintainer to review your PR labels Jul 14, 2024
@Drulikar Drulikar requested a review from a team July 19, 2024 03:58
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bit funky looking but it works. sprites approved 👍

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Jul 25, 2024
@harryob harryob removed the Stale Exempt PR can't go stale label Jul 25, 2024
code/modules/mob/living/carbon/xenomorph/XenoProcs.dm Outdated Show resolved Hide resolved
code/modules/mob/mob_defines.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 25, 2024 09:39
@Diegoflores31 Diegoflores31 marked this pull request as ready for review August 2, 2024 00:44
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they should have also pass flags also for other xenos moving into them (much like how you can move into a lesser's tile unimpeded). See discord for gif.

@Drulikar Drulikar marked this pull request as draft August 3, 2024 05:42
@Zenith00000
Copy link
Contributor

Yeah they need damage overlays. Also I don't think you should be able to attack while crawling and especially not tail-stab. Another thing is the lessers probably don't need the ability to hide/crawl at all, as they're already tiny enough.

@Diegoflores31
Copy link
Contributor Author

Yeah they need damage overlays. Also I don't think you should be able to attack while crawling and especially not tail-stab. Another thing is the lessers probably don't need the ability to hide/crawl at all, as they're already tiny enough.

hide ability is not coming back . it causes conficts with crawling .

@Tyranicranger4
Copy link
Contributor

Tyranicranger4 commented Aug 4, 2024

at the cost of some speed and being unable to use abilities.

Drones using the healer strain are capable of using their healing ability while crawling. Pretty potent given the recent changes to it and the fact that crawling removes any risk of you accidentally bodyblocking the person you're trying to heal.

@Diegoflores31
Copy link
Contributor Author

Drones using the healer strain are capable of using their healing ability while crawling. Pretty potent given the recent changes to it and the fact that crawling removes any risk of you accidentally bodyblocking the person you're trying to heal.

will fix

@Diegoflores31
Copy link
Contributor Author

Diegoflores31 commented Aug 4, 2024

UPDATE :::
-unrelated bugfix : Abilities that are not usable now are properly set to red color ( its been not working for a long time lol)
-tail stab now forces you to stand up and locks you out of stalk mode for a while
-some abilities that were bypassing stalk mode restrictions were tweaked and now are not usable while stalking

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Aug 4, 2024
@Drulikar Drulikar marked this pull request as draft August 4, 2024 09:19
@Diegoflores31 Diegoflores31 marked this pull request as ready for review August 4, 2024 10:44
cm13-github added a commit that referenced this pull request Aug 4, 2024
cm13-github added a commit that referenced this pull request Aug 4, 2024
cm13-github added a commit that referenced this pull request Aug 5, 2024
cm13-github added a commit that referenced this pull request Aug 5, 2024
@Comxy
Copy link
Contributor

Comxy commented Aug 6, 2024

-Removed Hide from runner , the only xeno with hide ability aside from larvas and huggers. that should fix any conflict. -runners can use stalking now as a replacement

What made you want to nerf runners ability to hide to where they are slowed down because of it, but not only that, now they cannot stay hidden while fighting.

Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wounds states are missing
image

@@ -11,6 +11,7 @@
armor_deflection = XENO_NO_ARMOR
evasion = XENO_EVASION_MEDIUM
speed = XENO_SPEED_TIER_7
walk_modifier = XENO_SPEED_HELLHOUND // no penalty to crawling
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
walk_modifier = XENO_SPEED_HELLHOUND // no penalty to crawling

This doesn't need an exception.

@@ -11,6 +11,7 @@
armor_deflection = XENO_NO_ARMOR
evasion = XENO_EVASION_LOW
speed = XENO_SPEED_TIER_6
walk_modifier = XENO_SPEED_HELLHOUND
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
walk_modifier = XENO_SPEED_HELLHOUND

This doesn't need an exception.

@Drulikar Drulikar marked this pull request as draft August 7, 2024 04:11
layer = initial(layer)

if(MOVE_INTENT_STALK)
evasion_modifier += XENO_EVASION_MOD_ULTRA // this looks like a lot but evasion is broken and doesnt even work most of the time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also reduce the evasion mod

@harryob
Copy link
Member

harryob commented Aug 24, 2024

pr seems to be stale, let us know if you want it re-opening, or just make a fresh pr for it

@harryob harryob closed this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Feature Feature coder badge Fix Fix one bug, make ten more Needs Testing Need to test it on the guinea pigs (production server) Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game. Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants