Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors some lights #8197

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Colors some lights #8197

merged 5 commits into from
Jan 28, 2025

Conversation

nauticall
Copy link
Contributor

@nauticall nauticall commented Jan 21, 2025

About the pull request

Colors (stationary) lights in-game to be shades of warm white and blue, depending on their bulb color, rather than the pure white they currently are. Tinted lights (like those on dropships) also have their own colors now, visible especially in places like the hangar or on a landing pad.

Normal lights (whose bulbs are tinted yellow) now have a warm white, incandascent look to them, while blue lights give off a harsher bluish tint.

Explain why it's good for the game

Adds that sort of retro look to the game while leveraging the new lighting system's full potential. Colored lighting is in the game (as we've seen with things like flares) but the game doesn't do a whole lot to make use of it. Maybe this'll change that.

This PR also has the side-effect of making the game less straining on the eyes, like a sort of blue light filter.

Other lights like floodlights or flashlights still remain white (for now).

Screenshots

Actual colors may vary ingame due to slight adjustments.

Almayer (Click to show/hide)

image
image
image
image
image
image

Hybrisa (Click to show/hide)

image
image
image
image
image
image
image

Fiorina (Click to show/hide)

image
image
image

Changelog

🆑
add: Changed most structure lights in the game to be either an incandascent warm white/yellow, or a cold blue, depending on their bulb color.
/:cl:

@nauticall nauticall added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jan 21, 2025
@cmss13-ci cmss13-ci bot added the Feature Feature coder badge label Jan 21, 2025
cm13-github added a commit that referenced this pull request Jan 21, 2025
@blackcrystall
Copy link
Contributor

Would be cool if you make light on ship fading a lil better, because right now light power is 1, have it in range of 0.6 - 0.8 and play around with other values of stationary light (so it will fade on corners less clearly)

cm13-github added a commit that referenced this pull request Jan 21, 2025
cm13-github added a commit that referenced this pull request Jan 21, 2025
cm13-github added a commit that referenced this pull request Jan 21, 2025
@zzzmike zzzmike mentioned this pull request Jan 22, 2025
3 tasks
@Diegoflores31
Copy link
Contributor

weird color artifacts , also parts of the almayer that are not supposed to be dark are dark ( medbay for example)

image

@kommikas124
Copy link

What about adding a very tiny like a cigaret light to RTO backpacks as they have a red beacon ontop of them, and make the light more visible once someone's calling.

@blackcrystall
Copy link
Contributor

weird color artifacts , also parts of the almayer that are not supposed to be dark are dark ( medbay for example)

image

This because shuttles don't use lighting system

@hry-gh hry-gh added this pull request to the merge queue Jan 27, 2025
Merged via the queue into cmss13-devs:master with commit ef193e5 Jan 28, 2025
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants