-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors some lights #8197
Merged
Merged
Colors some lights #8197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nauticall
added
the
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
label
Jan 21, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 21, 2025
Would be cool if you make light on ship fading a lil better, because right now light power is 1, have it in range of 0.6 - 0.8 and play around with other values of stationary light (so it will fade on corners less clearly) |
cm13-github
added a commit
that referenced
this pull request
Jan 21, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 21, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 21, 2025
3 tasks
cm13-github
added a commit
that referenced
this pull request
Jan 23, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 23, 2025
This was referenced Jan 24, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 24, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 24, 2025
3 tasks
cm13-github
added a commit
that referenced
this pull request
Jan 24, 2025
What about adding a very tiny like a cigaret light to RTO backpacks as they have a red beacon ontop of them, and make the light more visible once someone's calling. |
cm13-github
added a commit
that referenced
this pull request
Jan 25, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 25, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 25, 2025
3 tasks
3 tasks
3 tasks
cm13-github
added a commit
that referenced
this pull request
Jan 26, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 26, 2025
cm13-github
added a commit
that referenced
this pull request
Jan 27, 2025
hry-gh
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature
Feature coder badge
Testmerge Candidate
we'll test this while you're asleep and the server has 10 players
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Colors (stationary) lights in-game to be shades of warm white and blue, depending on their bulb color, rather than the pure white they currently are. Tinted lights (like those on dropships) also have their own colors now, visible especially in places like the hangar or on a landing pad.
Normal lights (whose bulbs are tinted yellow) now have a warm white, incandascent look to them, while blue lights give off a harsher bluish tint.
Explain why it's good for the game
Adds that sort of retro look to the game while leveraging the new lighting system's full potential. Colored lighting is in the game (as we've seen with things like flares) but the game doesn't do a whole lot to make use of it. Maybe this'll change that.
This PR also has the side-effect of making the game less straining on the eyes, like a sort of blue light filter.
Other lights like floodlights or flashlights still remain white (for now).
Screenshots
Actual colors may vary ingame due to slight adjustments.
Almayer (Click to show/hide)
Hybrisa (Click to show/hide)
Fiorina (Click to show/hide)
Changelog
🆑
add: Changed most structure lights in the game to be either an incandascent warm white/yellow, or a cold blue, depending on their bulb color.
/:cl: