Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Streams] Dashboard linking #204309

Merged
merged 149 commits into from
Jan 7, 2025
Merged

[Streams] Dashboard linking #204309

merged 149 commits into from
Jan 7, 2025

Conversation

dgieselaar
Copy link
Member

@dgieselaar dgieselaar commented Dec 14, 2024 •
edited by kibanamachine
Loading

Links dashboard to Streams.

Changes:

simianhacker and others added 30 commits November 1, 2024 11:22
@simianhacker
Initial setup for streams plugin
5fe1078
@simianhacker
migrating to the streams naming schema; adding an abstraction for the…
6f940eb 
… fork conditions
@simianhacker
ensure forked streams are marked root:false
9b33808
@dgieselaar
Commit entities plugins
c8cd0f7
@dgieselaar
Move files into streams_*
7e8f2d7
@dgieselaar
Rename stuff & remove stuff
999dfef
@flash1293
stream management
d99a3ff
@flash1293
add delete and listing endpoint
0e89345
@flash1293
cleanup
9dd5fde
@flash1293
add resync endpoint
7400a3b
@dgieselaar
Remove cruft, handle package relocation
5140687
@dgieselaar
Streams table
797c93d
@dgieselaar
Only fetch histogram when DS exists
fcce628
@flash1293
more fixes
9d37219
@flash1293
more adjustments
d622fa1
@flash1293
some more fixes
fbc6c2a
@flash1293
Merge remote-tracking branch 'upstream/main' into init-streams-plugin
45787d0
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
e810f53 
…ocs'
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
e93ac17 
…fix'
@flash1293
add limits
cf9f349
@flash1293
Merge branch 'init-streams-plugin' of github.com:simianhacker/kibana …
0d676ed 
…into init-streams-plugin
@dgieselaar
Add streams to left nav
7b0a4e5
@flash1293
fix permissions
34f3c44
@flash1293
remove feature completely
0b7de24
@flash1293
cleanup
76ed81d
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
2427d2e 
…fix'
@flash1293
Merge branch 'main' into init-streams-plugin
2ad08f4
@flash1293
Merge branch 'main' into init-streams-plugin
c8d99ed
@dgieselaar
Merge commit '0d676edfc0681f18d3804e079bad09053bf32247' into init-str…
8c707d1 
…eams-app-plugin
@dgieselaar
[Observability] Split up observability-utils package
e6bb640
simianhacker
simianhacker approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@simianhacker simianhacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the dashboard deletion bug.

@dgieselaar dgieselaar enabled auto-merge (squash) January 7, 2025 15:59
gsoldevila added a commit that referenced this pull request Jan 7, 2025
@gsoldevila
Make saved_objects_tagging plugin shared (#205695)
a8579bb 
## Summary

So that it can be used from `streams_app` (o11y).
See  #204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`
@dgieselaar dgieselaar merged commit 28414ce into elastic:main Jan 7, 2025
10 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12659295244

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
streamsApp 178 200 +22

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
streams 9 13 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 182.2KB 190.3KB +8.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
streams 2 8 +6
Unknown metric groups

API count

id before after diff
streams 9 13 +4

References to deprecated APIs

id before after diff
streamsApp 0 2 +2

History

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 204309

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Jan 7, 2025
Merged
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
@gsoldevila @kowalczyk-krzysztof
Make saved_objects_tagging plugin shared (elastic#205695)
3ac6c01 
## Summary

So that it can be used from `streams_app` (o11y).
See  elastic#204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request Jan 7, 2025
@dgieselaar @simianhacker
@flash1293 @kibanamachine @elasticmachine @kowalczyk-krzysztof
[Streams] Dashboard linking (elastic#204309)
345e736 
Links dashboard to Streams.

Changes:
- Introduces `IndexStorageAdapter` to manage ES indices - see
https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md
for motivation
- Introduces `AssetClient` and `AssetService` to manage asset links with
`IndexStorageAdapter`
- `RepositorySupertestClient` to make it easier to use
`@kbn/server-route-repository` with FTR tests
- refactors related to above changes

---------

Co-authored-by: Chris Cowan <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Jan 7, 2025
Merged
@dgieselaar dgieselaar mentioned this pull request Jan 8, 2025
Merged
@dgieselaar
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jan 8, 2025
@dgieselaar
[Streams] Dashboard linking (elastic#204309)
0592b3f 
Links dashboard to Streams.

Changes:
- Introduces `IndexStorageAdapter` to manage ES indices - see
https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md
for motivation
- Introduces `AssetClient` and `AssetService` to manage asset links with
`IndexStorageAdapter`
- `RepositorySupertestClient` to make it easier to use
`@kbn/server-route-repository` with FTR tests
- refactors related to above changes

---------

Co-authored-by: Chris Cowan <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 28414ce)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/tsconfig.json
gsoldevila added a commit to gsoldevila/kibana that referenced this pull request Jan 8, 2025
@gsoldevila
Make saved_objects_tagging plugin shared (elastic#205695)
4ee28b5 
## Summary

So that it can be used from `streams_app` (o11y).
See  elastic#204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`

(cherry picked from commit a8579bb)

# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-relocate/utils/relocate.ts
@kibanamachine kibanamachine mentioned this pull request Jan 8, 2025
Merged
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
@gsoldevila @crespocarlos
Make saved_objects_tagging plugin shared (elastic#205695)
489d777 
## Summary

So that it can be used from `streams_app` (o11y).
See  elastic#204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`
crespocarlos pushed a commit to crespocarlos/kibana that referenced this pull request Jan 8, 2025
@dgieselaar @simianhacker
@flash1293 @kibanamachine @elasticmachine @crespocarlos
[Streams] Dashboard linking (elastic#204309)
74d025d 
Links dashboard to Streams.

Changes:
- Introduces `IndexStorageAdapter` to manage ES indices - see
https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md
for motivation
- Introduces `AssetClient` and `AssetService` to manage asset links with
`IndexStorageAdapter`
- `RepositorySupertestClient` to make it easier to use
`@kbn/server-route-repository` with FTR tests
- refactors related to above changes

---------

Co-authored-by: Chris Cowan <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
This was referenced Jan 8, 2025
Merged
Merged
Merged
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 9, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

dgieselaar added a commit that referenced this pull request Jan 10, 2025
@dgieselaar @kibanamachine @flash1293
[8.x] [Streams] Dashboard linking (#204309) (#205842)
bb9d120 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Streams] Dashboard linking
(#204309)](#204309)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Dario
Gieselaar","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-07T21:04:42Z","message":"[Streams]
Dashboard linking (#204309)\n\nLinks dashboard to
Streams.\n\nChanges:\n- Introduces `IndexStorageAdapter` to manage ES
indices -
see\nhttps://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md\nfor
motivation\n- Introduces `AssetClient` and `AssetService` to manage
asset links with\n`IndexStorageAdapter`\n- `RepositorySupertestClient`
to make it easier to use\n`@kbn/server-route-repository` with FTR
tests\n- refactors related to above
changes\n\n---------\n\nCo-authored-by: Chris Cowan
<[email protected]>\nCo-authored-by: Joe Reuter
<[email protected]>\nCo-authored-by: kibanamachine
<[email protected]>\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"28414ce988f604f3d0ecbb6c484d3cd25ec8408b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:version","v8.18.0","Feature:Streams"],"number":204309,"url":"https://github.com/elastic/kibana/pull/204309","mergeCommit":{"message":"[Streams]
Dashboard linking (#204309)\n\nLinks dashboard to
Streams.\n\nChanges:\n- Introduces `IndexStorageAdapter` to manage ES
indices -
see\nhttps://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md\nfor
motivation\n- Introduces `AssetClient` and `AssetService` to manage
asset links with\n`IndexStorageAdapter`\n- `RepositorySupertestClient`
to make it easier to use\n`@kbn/server-route-repository` with FTR
tests\n- refactors related to above
changes\n\n---------\n\nCo-authored-by: Chris Cowan
<[email protected]>\nCo-authored-by: Joe Reuter
<[email protected]>\nCo-authored-by: kibanamachine
<[email protected]>\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"28414ce988f604f3d0ecbb6c484d3cd25ec8408b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204309","number":204309,"mergeCommit":{"message":"[Streams]
Dashboard linking (#204309)\n\nLinks dashboard to
Streams.\n\nChanges:\n- Introduces `IndexStorageAdapter` to manage ES
indices -
see\nhttps://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md\nfor
motivation\n- Introduces `AssetClient` and `AssetService` to manage
asset links with\n`IndexStorageAdapter`\n- `RepositorySupertestClient`
to make it easier to use\n`@kbn/server-route-repository` with FTR
tests\n- refactors related to above
changes\n\n---------\n\nCo-authored-by: Chris Cowan
<[email protected]>\nCo-authored-by: Joe Reuter
<[email protected]>\nCo-authored-by: kibanamachine
<[email protected]>\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"28414ce988f604f3d0ecbb6c484d3cd25ec8408b"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 10, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@gsoldevila @CAWilson94
Make saved_objects_tagging plugin shared (elastic#205695)
035f753 
## Summary

So that it can be used from `streams_app` (o11y).
See  elastic#204309

Steps to relocate:

1. Fetch latest `main`
2. Update the `group` and/or `visibility` in the module's manifest.
3. Run `node scripts/relocate --moveOnly
@kbn/saved-objects-tagging-plugin`
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
@dgieselaar @simianhacker
@flash1293 @kibanamachine @elasticmachine @CAWilson94
[Streams] Dashboard linking (elastic#204309)
3941cc3 
Links dashboard to Streams.

Changes:
- Introduces `IndexStorageAdapter` to manage ES indices - see
https://github.com/dgieselaar/kibana/blob/streams-app-asset-linking/x-pack/solutions/observability/packages/utils_server/es/storage/README.md
for motivation
- Introduces `AssetClient` and `AssetService` to manage asset links with
`IndexStorageAdapter`
- `RepositorySupertestClient` to make it easier to use
`@kbn/server-route-repository` with FTR tests
- refactors related to above changes

---------

Co-authored-by: Chris Cowan <[email protected]>
Co-authored-by: Joe Reuter <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miltonhultgren miltonhultgren miltonhultgren left review comments

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

@jloleysens jloleysens jloleysens approved these changes

@pheyos pheyos pheyos approved these changes

@adcoelho adcoelho adcoelho approved these changes

@simianhacker simianhacker simianhacker approved these changes

Assignees
No one assigned
Labels
backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dgieselaar @elasticmachine @kibanamachine @simianhacker @adcoelho @pheyos @miltonhultgren @jloleysens @tommyers-elastic @flash1293