helm upgrade uses reuse-values by default
#525
Comments
|
I faced the exactly same issue. When I added new items in values.yaml, |
use my fork for chart-testing until a change can be merged upstream to not use the `--reuse-values` flag helm/chart-testing#525
* redpanda: add console as subchart to redpanda * use my fork until we can get changes upstream use my fork for chart-testing until a change can be merged upstream to not use the `--reuse-values` flag helm/chart-testing#525 * allow postStart first-sasl-user hack to run even with only one replica * fix: type * Delete admin.conf --------- Co-authored-by: alejandroesc <[email protected]>
|
Guys, what is the historical reason for having chart-testing/pkg/tool/helm.go Line 74 in b8ad35c |
|
@joejulian Does the upgrade mode work in your case, if you remove |
|
@xDmitriev Yes, it works great. |
Could you please share your CLI arguments? Or is it just |
|
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This issue was closed because it has been stalled for 5 days with no activity. |
|
I think it is still useful to have and considering helm/helm#9653, we can also add support for I can try (relatively new here) and help take a look into it if needed :D |
|
This issue should not be closed IMHO, the hard coding of the reuse values makes the upgrade testing workflow essentially use when trying to test helm charts. Because adding new default values in the Helm chart is fine but not support by this testing tool at the moment. |
…rts#275) * redpanda: add console as subchart to redpanda * use my fork until we can get changes upstream use my fork for chart-testing until a change can be merged upstream to not use the `--reuse-values` flag helm/chart-testing#525 * allow postStart first-sasl-user hack to run even with only one replica * fix: type * Delete admin.conf --------- Co-authored-by: alejandroesc <[email protected]>
Is this a request for help?:
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT
Version of Helm and Kubernetes:
version.BuildInfo{Version:"v3.11.0", GitCommit:"472c5736ab01133de504a826bd9ee12cbe4e7904", GitTreeState:"clean", GoVersion:"go1.19.5"}
ct version 2.7.1
What happened:
Upgrade failed when adding a new subchart in the new version because the new default chart values are ignored when reuse-values is specified. This caused the overrides in the new parent chart's values to be omitted and the subcharts defaults were used instead. As those overrides are required for the subchart to be a subchart, this caused the upgrade to fail.
When testing without
reuse-valuesthe upgrade is performed correctly.Since using that flag is not a commonly documented way of upgrading charts, it should not be the default.
What you expected to happen:
I expected the common
helm upgrade <release> <chart> --waitto be executed.How to reproduce it (as minimally and precisely as possible):
Anything else we need to know:
The text was updated successfully, but these errors were encountered: