Add kernel image upload and download functionality #17
+197
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ivntsng
commented
Nov 19, 2024
ivntsng
commented
- Upload kernel images to listings
- Download and cache images locally
- Manage local image cache
codekansas
reviewed
Nov 20, 2024
| @@ -15,6 +16,7 @@ def cli() -> None: | |||
|
|
|||
| cli.add_command(urdf_cli, "urdf") | |||
| cli.add_command(pybullet_cli, "pybullet") | |||
| cli.add_command(kernel_images_cli, "kernel-images") | |||
There was a problem hiding this comment.
This will be annoying to type, use kernel instead
| @@ -13,7 +14,7 @@ def get_api_root() -> str: | |||
| Returns: | |||
| The base URL for the K-Scale Store API. | |||
| """ | |||
| return os.getenv("KSCALE_API_ROOT", "https://api.kscale.dev") | |||
| return os.getenv("KSCALE_API_ROOT", "https://api.kscale.dev/") | |||
There was a problem hiding this comment.
Hmm please revert this, if it is causing a bug then that means you are missing a leading slash somewhere else. This will be annoying if the user wants to override this environment variable and it's missing a trailing slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.