Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes to flaky MoveIt Servo integration tests #2962

Merged
merged 6 commits into from
Aug 11, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Aug 10, 2024

Description

I've been seeing servo integration tests flake every now and then, and found it improved when removing the node before trying to cancel the executor and join its spinning thread.

I also changed some incorrect / characters in the integration test launch files' static transform publisher. We were failing to get a proper state from the planning scene because the virtual joint was flagged as missing.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sea-bass sea-bass changed the title Remove node in teardown of flaky MoveIt Servo test fixture Small fixes to flaky MoveIt Servo integration tests Aug 10, 2024
@sea-bass sea-bass added this pull request to the merge queue Aug 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 11, 2024
@sea-bass sea-bass added this pull request to the merge queue Aug 11, 2024
Merged via the queue into main with commit aece55c Aug 11, 2024
10 of 13 checks passed
@sea-bass sea-bass deleted the remove-node-in-servo-integ-test branch August 11, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants