Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wave with Docker and Spack #4940

Draft
wants to merge 73 commits into
base: wave
Choose a base branch
from
Draft

Wave with Docker and Spack #4940

wants to merge 73 commits into from

Conversation

edmundmiller
Copy link
Contributor

@edmundmiller edmundmiller commented Feb 16, 2024 •
edited
Loading

For @matthdsm on #4935

Branched off from #4080

edmundmiller and others added 30 commits February 16, 2024 09:43
@edmundmiller
build: Add wave
9db4c91
@edmundmiller
build: Set strategy to dockerfile, conda then container
fe7665f
@edmundmiller
refactor: Remove container
59d3019
@edmundmiller
build: Add a repo to push to
67c62bd
@edmundmiller
ci(wave): Add wave build
f1d8649 
https://github.com/nodejs/docker-node/blob/3c4fa6daf06a4786d202f2f610351837806a0380/.github/workflows/build-test.yml#L29
@edmundmiller
ci(wave): Switch to all_changed_files
5415a42
@edmundmiller
ci(wave): Only look for envronment.ymls
36414d1
@edmundmiller
dummy: Change env
25957b2
@edmundmiller
ci(wave): Remove raw format
5d3f4f1
@edmundmiller
ci(wave): Try a bunch of different things at once
c79eb65
@edmundmiller
ci(wave): Remove redundant fromJson and wrap in an array
fac96ce
@edmundmiller
ci(wave): I have no idea what I'm doing
fc0121d
@edmundmiller
ci(wave): Wrap it
5d875d7
@edmundmiller
ci(wave): Found an example
e0ce27d 
https://github.com/tj-actions/changed-files/blob/main/.github/workflows/matrix-test.yml
@edmundmiller
ci(wave): Maybe quotes?
5d37376
@edmundmiller
ci(wave): That'll do it
0073c28
@edmundmiller
ci(wave): Fix wave install
5ead848
@edmundmiller
ci(wave): Hard code an image
1e89bff
@edmundmiller
ci(wave): Add secrets
ea9ab86
@edmundmiller
feat: Try a different files structure
8571bc9
@edmundmiller
ci(wave): First stab at building singularity images
d6ef54a
@edmundmiller
fixup! feat: Try a different files structure
6a4af4d
@edmundmiller
ci(wave): Add profile to matrix
5410b46
@edmundmiller
ci(wave): Give up on fancy substitution
1090212
@edmundmiller @ewels
ci(wave): Add await
a3bf363 
Co-authored-by: ewels <[email protected]>
@edmundmiller
ci(wave): Switch to quay
a3fa9d0
@edmundmiller
test(wave): Add freeze and update build repo
adafa32
@edmundmiller
refactor(wave): What happens if I add a container?
59f6b4f
@edmundmiller
refactor(wave): Have both bowtie modules use the same env
d7cbe39 
For the sake of demonstration
@edmundmiller
test: Cut out using wave on tests
7edc6d3
@matthdsm
Copy link
Contributor

No apologies needed! I just wasn't following what what happening exactly 😛
Nice work on the wave stuff!

@edmundmiller edmundmiller mentioned this pull request Feb 19, 2024
Open
@edmundmiller
Copy link
Contributor Author

@maxulysse This was from the maintainer meeting on Friday. 116adce

Idk if that's what you were thinking about too, but it was at least what was in my head. 🙃

@matthdsm
Copy link
Contributor

That's exactly what the Broad does. Does it work??

@matthdsm
Copy link
Contributor

Apparently not 😞

Requirement 'gatkPythonPackageArchive.zip' looks like a filename, but the file does not exist
Processing ./gatkPythonPackageArchive.zip\nERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/tmp/gatkPythonPackageArchive.zip

@edmundmiller
Copy link
Contributor Author

I think we'd have to get the path right, and even then I'm not sure if it'll play nicely with the conda install

@edmundmiller
Copy link
Contributor Author

edmundmiller commented Feb 26, 2024 •
edited
Loading

I stand corrected. https://simonwillison.net/2022/Apr/24/pip-install-github/

Thought it had to be a git repo!

@edmundmiller
Copy link
Contributor Author

So it worked... but it broke wave...

@ksenia-krasheninnikova ksenia-krasheninnikova mentioned this pull request Apr 24, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drpatelh drpatelh Awaiting requested review from drpatelh drpatelh will be requested when the pull request is marked ready for review drpatelh is a code owner

@JoseEspinosa JoseEspinosa Awaiting requested review from JoseEspinosa JoseEspinosa will be requested when the pull request is marked ready for review JoseEspinosa is a code owner

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen FriederikeHanssen will be requested when the pull request is marked ready for review FriederikeHanssen is a code owner

@priyanka-surana priyanka-surana Awaiting requested review from priyanka-surana priyanka-surana will be requested when the pull request is marked ready for review priyanka-surana is a code owner

@ryanjameskennedy ryanjameskennedy Awaiting requested review from ryanjameskennedy ryanjameskennedy will be requested when the pull request is marked ready for review ryanjameskennedy is a code owner

@KevinMenden KevinMenden Awaiting requested review from KevinMenden KevinMenden will be requested when the pull request is marked ready for review KevinMenden is a code owner

@matthdsm matthdsm Awaiting requested review from matthdsm matthdsm will be requested when the pull request is marked ready for review matthdsm is a code owner

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
None yet
Milestone
Wave/Seqera Containers Migration
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundmiller @matthdsm