Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shigapass #6636

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Shigapass #6636

wants to merge 11 commits into from

Conversation

maxlcummins
Copy link

@maxlcummins maxlcummins commented Sep 13, 2024 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@maxlcummins maxlcummins requested a review from a team as a code owner September 13, 2024 02:20
@maxlcummins maxlcummins requested review from SPPearce and removed request for a team September 13, 2024 02:20
maxlcummins added a commit to maxlcummins/modules that referenced this pull request Sep 16, 2024
@maxlcummins
add main.nf.test.snap and update main.nf.test as per pull request nf-…
5fd2db1 
…core#6636
@SPPearce
Copy link
Contributor

If you ask on the nf-core slack github-invitations channel you can be added to the organisation and then the tests will run.

SPPearce
SPPearce approved these changes Sep 20, 2024
View reviewed changes
modules/nf-core/shigapass/main.nf Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SPPearce SPPearce SPPearce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxlcummins @SPPearce