Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests from travis to drone #660

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Move tests from travis to drone #660

merged 1 commit into from
Dec 6, 2018

Conversation

paurakhsharma
Copy link
Member

@paurakhsharma paurakhsharma commented Nov 23, 2018 •
edited by phil-davis
Loading

Description

Move all tests from travis.yml to drone.yml.

Related issue: #659

@paurakhsharma paurakhsharma added this to the development milestone Nov 23, 2018
@paurakhsharma paurakhsharma self-assigned this Nov 23, 2018
@paurakhsharma paurakhsharma force-pushed the move-travis-to-drone branch 2 times, most recently from fd254fd to 1fcb867 Compare November 23, 2018 10:55
@individual-it
Copy link
Member

@ownclouders rebase

@paurakhsharma
Copy link
Member Author

@phil-davis, Please review this.

@codecov
Copy link

codecov bot commented Nov 26, 2018 •
edited
Loading

Codecov Report

Merging #660 into master will decrease coverage by 1.4%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #660      +/-   ##
============================================
- Coverage     85.47%   84.07%   -1.41%     
  Complexity      500      500              
============================================
  Files            38       45       +7     
  Lines          1811     1796      -15     
============================================
- Hits           1548     1510      -38     
- Misses          263      286      +23
Impacted Files Coverage Δ Complexity Δ
lib/Formatter/FileFormatter.php 92.5% <0%> (-0.69%) 14% <0%> (ø)
lib/Controller/Feed.php 95.23% <0%> (-0.32%) 6% <0%> (ø)
lib/FilesHooks.php 77.92% <0%> (-0.24%) 80% <0%> (ø)
lib/UserSettings.php 91.07% <0%> (-0.16%) 22% <0%> (ø)
lib/AppInfo/Application.php 79.88% <0%> (-0.12%) 26% <0%> (ø)
lib/GroupHelper.php 98.92% <0%> (-0.06%) 24% <0%> (ø)
lib/BackgroundJob/EmailNotification.php 100% <0%> (ø) 17% <0%> (ø) ⬇️
lib/MailQueueHandler.php 100% <0%> (ø) 18% <0%> (ø) ⬇️
appinfo/routes.php 100% <0%> (ø) 0% <0%> (ø) ⬇️
lib/Controller/Activities.php 100% <0%> (ø) 3% <0%> (ø) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1204d5...dc0603d. Read the comment docs.

phil-davis
phil-davis requested changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and do not commit tests/output/clover.xml to the repo

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@paurakhsharma paurakhsharma force-pushed the move-travis-to-drone branch 3 times, most recently from ee10d6c to a754cfe Compare November 26, 2018 09:57
phil-davis
phil-davis approved these changes Nov 26, 2018
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@paurakhsharma
Copy link
Member Author

paurakhsharma commented Nov 26, 2018 •
edited
Loading

@DeepDiver1975 please review this. And merge this if you are happy.

DeepDiver1975
DeepDiver1975 requested changes Nov 26, 2018
View reviewed changes
tests/unit/ApiTest.php Outdated Show resolved Hide resolved
@paurakhsharma paurakhsharma force-pushed the move-travis-to-drone branch 2 times, most recently from e713a57 to 537817d Compare November 27, 2018 10:31
@paurakhsharma
Copy link
Member Author

Drone is not running. Have to wait until drone is fixed.

@paurakhsharma paurakhsharma changed the title Move tests from travis to drone [WIP-Do-not-Merge] Move tests from travis to drone Nov 28, 2018
@paurakhsharma paurakhsharma changed the title [WIP-Do-not-Merge] Move tests from travis to drone Move tests from travis to drone Nov 29, 2018
@paurakhsharma paurakhsharma force-pushed the move-travis-to-drone branch 2 times, most recently from 03b2c20 to ab28f83 Compare November 29, 2018 06:24
@phil-davis
Copy link
Contributor

phil-davis commented Nov 29, 2018 •
edited
Loading

tests/Unit/js/package-lock.json seems to have been added?
Is that an accident?

  • fixed now, and has been added to gitignore

phil-davis
phil-davis reviewed Nov 29, 2018
View reviewed changes
.drone.yml Outdated Show resolved Hide resolved
DeepDiver1975
DeepDiver1975 previously requested changes Nov 29, 2018
View reviewed changes
.drone.yml Outdated Show resolved Hide resolved
.drone.yml Outdated Show resolved Hide resolved
@phil-davis phil-davis mentioned this pull request Nov 29, 2018
Merged
4 tasks
patrickjahns
patrickjahns reviewed Nov 29, 2018
View reviewed changes
.drone.yml Outdated Show resolved Hide resolved
patrickjahns
patrickjahns previously requested changes Nov 29, 2018
View reviewed changes
.drone.yml Outdated Show resolved Hide resolved
@paurakhsharma paurakhsharma force-pushed the move-travis-to-drone branch 2 times, most recently from c826ee4 to 932d63a Compare November 30, 2018 06:19
@phil-davis
Copy link
Contributor

@DeepDiver1975 @patrickjahns review comments have been addressed.
Please review again.
And adjust the repo to require drone, not require travis, and I think security/snyk should look for tests/Unit/js/package.json - that will let make more green ticks for CI.

@phil-davis phil-davis dismissed stale reviews from patrickjahns and DeepDiver1975 December 5, 2018 03:38

code has been modified since review

@PVince81 PVince81 merged commit 63b62ff into master Dec 6, 2018
@delete-merged-branch delete-merged-branch bot deleted the move-travis-to-drone branch December 6, 2018 07:21
phil-davis
phil-davis reviewed Feb 12, 2019
View reviewed changes
Makefile

# Builds the source package for the app store, ignores php and js tests
.PHONY: appstore
appstore:
Copy link
Contributor

@phil-davis phil-davis Feb 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question to self: was this stuff here when I approved this PR? If so, why did I approve it? And/or why did it get added in this PR? Some accidental code pasting?

The Makefile script has no definition of appstore_package_name or appstore_build_directory so this target fails.

@paurakhsharma do you remember about this?

This was referenced Feb 12, 2019
Closed
Merged
@patrickjahns patrickjahns removed this from the development milestone Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@patrickjahns patrickjahns patrickjahns left review comments

@DeepDiver1975 DeepDiver1975 DeepDiver1975 left review comments

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@paurakhsharma paurakhsharma

Labels
3 - To review dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@paurakhsharma @individual-it @phil-davis @DeepDiver1975 @patrickjahns @PVince81