Move phpunit.xml to root folder of repo

[phil-davis]

Issue #272

• Move phpunit.xml to root folder of repo
• add PHP unit targets to Makefile
• use those targets in drone
• implement coding-standard checks

[codecov]

Codecov Report

Merging #273 into master will decrease coverage by 1.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #273      +/-   ##
============================================
- Coverage      59.1%   57.74%   -1.37%     
+ Complexity      277      276       -1     
============================================
  Files            33       33              
  Lines          1274     1214      -60     
============================================
- Hits            753      701      -52     
+ Misses          521      513       -8

Impacted Files	Coverage Δ	Complexity Δ
templates/settings.php	0% <ø> (ø)	0 <0> (ø)	⬇️
lib/BackgroundScanner.php	51.11% <0%> (-5.46%)	19% <0%> (-1%)
lib/Status.php	72.72% <0%> (-2.28%)	26% <0%> (ø)
lib/AvirWrapper.php	86.27% <0%> (-1.23%)	24% <0%> (ø)
lib/Controller/SettingsController.php	88.46% <0%> (-0.83%)	6% <0%> (ø)
lib/Scanner/Local.php	92.3% <0%> (-0.8%)	5% <0%> (ø)
lib/Db/RuleMapper.php	94.95% <0%> (-0.73%)	8% <0%> (ø)
lib/AppConfig.php	81.66% <0%> (-0.6%)	21% <0%> (ø)
lib/Scanner/AbstractScanner.php	81.81% <0%> (-0.54%)	25% <0%> (ø)
appinfo/application.php	75.3% <0%> (-0.31%)	15% <0%> (ø)
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c166bac...449ff63. Read the comment docs.

[phil-davis]

I made this a lot like the Makefile and CI of password_policy

Please review and see what else I should be adjusting.

[DeepDiver1975]

I really wonder why coverage is dropping .....

[phil-davis]

@DeepDiver1975 @patrickjahns @PVince81 this is ready for review again.
I got rid of the local phpunit and it uses phpunit from core, in the same way that data_exporter is doing.

[patrickjahns]

The rules for phan/phpstan have already been added - though I don't see the composer files necessary for this

[phil-davis]

I pasted in the "standard" rules for "all" the make targets. Then they are there "ready to go".
@patrickjahns do you want me to remove them?

code has been updated

[phil-davis]

I added coding standard matrix entry for PHP 5.6. This verifies that the code does not have any PHP7-specific stuff in it.

[phil-davis]

Rebased to trigger drone again.

[phil-davis]

@patrickjahns @DeepDiver1975 drone is passing.
Ready for review again.

[patrickjahns]

Thinking about https://github.com/owncloud/files_antivirus/pull/273/files/e6210e7ee74237f4e7b4ce77f2f49f2f513ae737#diff-4284501ea35da71f86e08fa8e56fdead
We probably require a rule that cleans up dependencies ( remove vendor / - vendor-bin//vendor - vendor-bin//composer.lock) folders to avoid platforming pinning when not necessary.

Opinions?

[phil-davis]

We probably require a rule that cleans up dependencies ( remove vendor / - vendor-bin//vendor - vendor-bin//composer.lock) folders to avoid platforming pinning when not necessary.

Yes, that would be useful - specially when dropping back to PHP5.6 in a local dev environment to investigate weird stuff. I raised issue owncloud/QA#604 because this is a cross-app thing. We need to decide the clean* target names and what they do once, then implement in all relevant repos.

[phil-davis]

@patrickjahns any more code changes needed for this PR?

[phil-davis]

@patrickjahns after the little side discussion about PHP_VERSION=${PHP_VERSION} we are all sorted. Please review again and approve if happy.

[phil-davis]

Today's "standard" CI-script changes have been made, like reference to tests/output/*.xml and content of .gitgnore. The previously long list of jumbled commits has been squashed. The scripts here should match the "new current style standard"

@patrickjahns @DeepDiver1975 ready for review again.

[phil-davis]

Rebased and resolved conflicts.
@patrickjahns @DeepDiver1975 please review. I like to be able to finish things.

[phil-davis]

Rebased to get back in the drone queue - the previous drone CI had fails related to the corrupt core master QA tarball this morning.