use npm packages #34
use npm packages #34
Conversation
🦋 Changeset detectedLatest commit: 653f2a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Looks good after green CI + external deps are swapped in |
turbocrime
force-pushed
the
turbocrime/use-packages
branch
3 times, most recently
from
7e36a0e
to
a636256
Compare
turbocrime
force-pushed
the
turbocrime/use-packages
branch
from
f1b5bda
to
653f2a6
Compare
| @@ -7,6 +7,9 @@ on: | |||
| branches: | |||
| - main | |||
|
|
|||
| env: | |||
| DO_NOT_TRACK: 1 | |||
There was a problem hiding this comment.
replaces turbo telemetry disable command
| key: ${{ hashFiles('**/Cargo.lock') }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ github.ref }}-${{ github.sha }}-built | ||
| restore-keys: ${{ hashFiles('**/Cargo.lock') }}-${{ hashFiles('pnpm-lock.yaml') }}-${{ github.ref }}-${{ github.sha }}-compiled | ||
| key: ${{ hashFiles('pnpm-lock.yaml') }}-${{ github.ref }}-${{ github.sha }}-publish | ||
| restore-keys: ${{ hashFiles('pnpm-lock.yaml') }}-${{ github.ref }}-${{ github.sha }}-test |
There was a problem hiding this comment.
possibly restore cache from a successful test run
|
why doesn't locally linking package deps like this work?
|
part of this is syncpack, which doesn't know how to compare paths except by a literal string match, and can't compare semver matchers with paths you may also be having problems with module resolution, which was not addressed by the packaging work, and package builds, which turbo won't assist with or understand for external packages 'link' is really only useful for packages that have no build step, or are a directory essentially equivalent to an unpacked tarball |
|
Nice job here! 🎊 |
includes some rebased code that was dropped