feat: Rectangular ROIs

[gselzer]

This PR brings support for (rectangular) ROIs to the new array viewer. This work was updated from the original viewer, and needs to be cleaned up, but does pass current automated tests and works well in my limited manual testing.

TODO:

• Clean - probably lots of cruft from the update
• Test - I remember this being tricky and being why I was motivated to explore a fix to consider passing the model directly to gui view objects #70, but let's give it another shot.

[codecov]

Codecov Report

Attention: Patch coverage is 82.40418% with 101 lines in your changes missing coverage. Please review.

Project coverage is 79.02%. Comparing base (c3cf013) to head (b3cfbf2).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
src/ndv/views/_jupyter/_app.py	14.28%	24 Missing ⚠️
src/ndv/v1/_old_viewer.py	52.77%	17 Missing ⚠️
src/ndv/views/_qt/_app.py	32.00%	17 Missing ⚠️
src/ndv/views/_pygfx/_array_canvas.py	89.33%	16 Missing ⚠️
src/ndv/views/_wx/_app.py	58.82%	7 Missing ⚠️
src/ndv/controllers/_array_viewer.py	90.56%	5 Missing ⚠️
src/ndv/views/_vispy/_array_canvas.py	96.81%	5 Missing ⚠️
src/ndv/views/_pygfx/_histogram.py	33.33%	2 Missing ⚠️
src/ndv/views/_vispy/_histogram.py	33.33%	2 Missing ⚠️
src/ndv/views/_wx/_array_view.py	86.66%	2 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   76.81%   79.02%   +2.21%     
==========================================
  Files          49       51       +2     
  Lines        4930     5107     +177     
==========================================
+ Hits         3787     4036     +249     
+ Misses       1143     1071      -72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gselzer]

Still need to clean up the tests, but I think this is ready for your eyes @tlambert03. Points for discussion:

• This PR introduces the ArrayViewerModel to maintain gui state - right now, the only field is InteractionMode, but this could house other things (maybe camera state?) in future PRs. I don't really like that name, could rename UIModel...
• This PR doesn't really account for future needs (i.e. multiple rois, different shapes, etc. as well as a ROI controller to wrangle them) - my thinking was that this could be future PRs. In addition, I was planning on adding in the integrations I want (such as using the ROI to narrow the histogram down to a region) in future PRs.

[tlambert03]

i think this is looking very nice, and the runtime behavior is great! I looked most closely at everything outside of the actual vispy and pygx implementations (the general model and hookup of it all). If there was anything about the specific graphics implementations that you want me to take a close look at, go ahead and comment inline.

otherwise, do whatever final cleanup/testing you want to add and then let's get this in!

[gselzer]

@tlambert03 this morning I got the build working (as best as I could, as you've also noticed tests still segfault sometimes), and added some tests. Let me know what you think of the tests - if you like it, I think this is ready for merge!

[tlambert03]

LGMT! 🚀 automerge is on