Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rectangular ROIs #114

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: Rectangular ROIs #114

wants to merge 6 commits into from

Conversation

gselzer
Copy link
Collaborator

@gselzer gselzer commented Jan 21, 2025

This PR brings support for (rectangular) ROIs to the new array viewer. This work was updated from the original viewer, and needs to be cleaned up, but does pass current automated tests and works well in my limited manual testing.

TODO:

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 57.05394% with 207 lines in your changes missing coverage. Please review.

Project coverage is 62.65%. Comparing base (133f7c1) to head (9c6f9c2).

Files with missing lines Patch % Lines
src/ndv/views/_vispy/_array_canvas.py 47.40% 81 Missing ⚠️
src/ndv/views/_pygfx/_array_canvas.py 47.29% 78 Missing ⚠️
src/ndv/v1/_old_viewer.py 54.28% 16 Missing ⚠️
src/ndv/views/_qt/_app.py 17.64% 14 Missing ⚠️
src/ndv/controllers/_array_viewer.py 78.26% 10 Missing ⚠️
src/ndv/views/_jupyter/_array_view.py 70.00% 3 Missing ⚠️
src/ndv/views/_qt/_array_view.py 88.46% 3 Missing ⚠️
src/ndv/_types.py 85.71% 1 Missing ⚠️
src/ndv/models/_roi_model.py 94.11% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (133f7c1) and HEAD (9c6f9c2). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (133f7c1) HEAD (9c6f9c2)
42 35
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   72.43%   62.65%   -9.79%     
==========================================
  Files          48       50       +2     
  Lines        4622     4742     +120     
==========================================
- Hits         3348     2971     -377     
- Misses       1274     1771     +497     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant